DVDDemuxFFmpeg: set namespace for UrlOptions class #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to xbmc#344 use correct class methods from ffmpegdirect UrlOptions.cpp and not from Kodi which uses same class name before 2025-10-31 18:29:33.622 T:10030 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: ' after 2025-10-31 18:31:16.884 T:10126 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: 0'
phunkyfish
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also related to #344 but fixes generic problem passing a value
use correct class methods from ffmpegdirect UrlOptions.cpp and not from Kodi which uses same class name
now the ffmpeg option value is passed to ffmpeg
before
2025-10-31 18:29:33.622 T:10030 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: 'after
2025-10-31 18:31:16.884 T:10126 debug <inputstream.ffmpegdirect>: CDVDDemuxFFmpeg::GetFFMpegOptionsFromInput() adding ffmpeg option 'extension_picky: 0'