General cleanup

index.html

@@ -85,8 +85,8 @@ <h1>This is a proposal</h1>
       <script src="js/cuore/Cuore.HandlerSet.js"></script>
 
 
-      <script src="js/new_cuore/Cuore.Service.js"></script>
-      <script src="js/new_cuore/Cuore.Services.Label.js"></script>
+      <script src="js/new_cuore/Service.js"></script>
+      <script src="js/new_cuore/Services.Label.js"></script>
       <script src="js/cuore/Services/Cuore.Services.Null.js"></script>
 
 

js/cuore/Cuore.Bus.js

@@ -25,48 +25,43 @@ CUORE.Bus = (function(undefined) {
     }
 
     function unsubscribe(subscriber, events) {
-        var i;
-
         if (typeof events == "string") {
             _removeSubscription(_createSubscription(subscriber, events));
             return;
         }
 
-        for (i = 0; i < events.length; i++) {
-            _removeSubscription(_createSubscription(subscriber, events[i]));
-        }
+        events.forEach(function (event) {
+             _removeSubscription(_createSubscription(subscriber, event));
+        });
     }
 
     function hasSubscriptions() {
         return (subscriptions.length > 0);
     }
 
     function subscribers(theEvent) {
-        var selectedSubscribers = [],
-            i, subscription,
-            len = subscriptions.length;
+        var selectedSubscribers = [];
 
-        for (i = 0; i < len; i++) {
-            subscription = subscriptions[i];
+        subscriptions.forEach(function (subscription) {
             if (subscription.eventName === theEvent) {
                 selectedSubscribers.push(subscription.subscriber);
             }
-        }
+        });
+
         return selectedSubscribers;
     }
 
     function emit(eventName, params) {
-        var subscribersList = this.subscribers(eventName),
-            i, len = subscribersList.length;
+        var subscribersList = this.subscribers(eventName);
 
         debug("Bus.emit (event, params)");
         debug(eventName);
         debug(params);
         debug("------------");
 
-        for (i = 0; i < len; i++) {
-            subscribersList[i].eventDispatch(eventName, params);
-        }
+        subscribersList.forEach(function (current) {
+             current.eventDispatch(eventName, params);
+        });
     }
 
     function debug(object) {
@@ -100,12 +95,16 @@ CUORE.Bus = (function(undefined) {
 
         for (i = 0; i < len; i++) {
             if (theSubscription.equals(subscriptions[i])) {
-                subscriptions.splice(i, 1);
+                this._removeAt(subscriptions, i);
                 return;
             }
         }
     }
 
+    function _removeAt (index, array) {
+        array.splice(index, 1);
+    }
+
     function _validSubscriber(subscriber) {
         return subscriber.eventDispatch;
     }

js/cuore/Cuore.Journey.js

@@ -2,11 +2,14 @@ CUORE.Journey = CUORE.Class(null, {
 
     init: function(start, end) {
         var allValues = (start && end);
+        var minutesInADay;
 
         this.itsGranularity = 60;
         this.minutesInAnHour = 60;
+        minutesInADay = 24 * this.minutesInAnHour;
+
         this.start = (allValues) ? this._convertToMinutesDay(start) : 0;
-        this.end = (allValues) ? this._convertToMinutesDay(end) : 1440;
+        this.end = (allValues) ? this._convertToMinutesDay(end) : minutesInADay;
     },
 
     starts: function() {