add: e2e test automation#11
Open
Rink9 wants to merge 1 commit into
Open
Conversation
xaviranik
requested changes
Apr 1, 2022
| "homepage": "https://github.com/rink9/boostimer-e2e#readme", | ||
| "devDependencies": { | ||
| "@wordpress/e2e-test-utils": "^4.11.0", | ||
| "@wordpress/e2e-tests": "^1.20.0", |
| import { URLS } from '../utils/urls'; | ||
|
|
||
| describe( 'Sale timer test cases', () => { | ||
| it( 'should set sale timer', async () => { |
Owner
There was a problem hiding this comment.
Kindly adhere to WordPress JavaScript Coding Standards in terms of spacing and indentions. Write doc-block if necessary.
| @@ -0,0 +1,2 @@ | |||
| <?php | |||
| /* mimicing the dev files */ No newline at end of file | |||
Owner
There was a problem hiding this comment.
We don't need this file here. Kindly remove the src directory.
| } | ||
| } | ||
|
|
||
| export async function isElementExists( element ){ |
Owner
There was a problem hiding this comment.
Consider this approach:
export async function isElementExists( element ){
return await page.$( element ) !== null;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added e2e test automation for boostimer