Fix script injection security issues in workflows#44
Merged
martinohansen merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Move untrusted GitHub context values to env vars to prevent script injection attacks per GitHub security best practices.
|
📖 Docs Preview Preview URL: https://xata.io/next/preview-path?path=/docs-preview/xataio:fix/actionlint-script-injection/ |
SferaDev
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move untrusted GitHub context values out of inline shell scripts into environment variables to prevent script injection attacks.
Security concern
Directly interpolating
${{ github.head_ref }}or${{ github.event.pull_request.head.ref }}intorun:scripts allows an attacker to inject arbitrary shell commands by naming a branch with a payload likex"; malicious command; echo ".Fix
Each untrusted value is assigned to an environment variable in the step's
env:block and referenced as$VAR_NAMEin the script body.See: https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions