Validate reproject input coordinate spacing#2204
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @puneetdixit200, thanks for the PR! Would you mind filing a quick New contributor introduction issue when you get a chance? It helps us point you at issues that fit what you'd like to work on. Most fields are optional. Reviewing your PR doesn't depend on it, just a friendly nudge. |
Contributor
|
@puneetdixit200 thanks for the submission, but this a duplicate PR with #2192 Closing this PR for now, but would be happy to chat and help get you setup for contribution. With some of the AI assisted workflows, issues and PRs are created close together so it can be hard to jump into an issue as there is a decent possibility its already being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reproject()andmerge()input x/y coordinates before CRS resolution.ValueErrormessages that include the worst step deviation.Closes #2184
Validation
uv run pytest -q xrspatial/tests/test_reproject.py::TestReproject::test_reproject_rejects_irregular_x_before_crs_resolution xrspatial/tests/test_reproject.py::TestReproject::test_reproject_rejects_non_monotonic_y xrspatial/tests/test_reproject.py::TestMerge::test_merge_rejects_irregular_input_coordsuv run pytest -q xrspatial/tests/test_reproject.py::TestReproject xrspatial/tests/test_reproject.py::TestMerge xrspatial/tests/test_reproject.py::TestMergeSameCrsYOrientation xrspatial/tests/test_reproject.py::TestMergeMixedNodata xrspatial/tests/test_reproject.py::TestMerge3DRejectionuv run pytest -q xrspatial/tests/test_reproject.py -k 'not test_vertical_crs_attr_is_epsg_int'uv run python -m compileall -q xrspatial/reproject/__init__.py xrspatial/tests/test_reproject.pygit diff --checkreproject()andmerge().Notes:
uv run pytest -q xrspatial/tests/test_reproject.pyrun reached 277 passed / 18 skipped, then failed inTestVerticalShift::test_vertical_crs_attr_is_epsg_intbecause local Python SSL certificate verification failed while downloading geoid data fromcdn.proj.org.uv run flake8 xrspatial/reproject/__init__.py xrspatial/tests/test_reproject.pyreports existing lint findings in those files; I left that unrelated cleanup out of this fix.AI-assisted review
Review notes: