Conversation
.github/workflows/deploy.yml
Outdated
There was a problem hiding this comment.
I am planning to deploy this via Azure (same as xCAD). I believe this is for GitHub Actions. Could you please remove this from the commit?
artem1t
left a comment
artem1t
left a comment
There was a problem hiding this comment.
Thanks a lot, this is a great job! I have added few comments. Basically, those are only related to the changes outside of the docs folder. To keep the PR clean, could you please revert any changes outside of docs folder (e.g. build, samples, src, templates, tests) and all the Github action files and only keep the changes in the docs folder?
There was a problem hiding this comment.
I think .gitignore are mainly kept as local files (not in the repo). Could you please remove from the repo?
There was a problem hiding this comment.
The .gitignore is meant to prevent committing unwanted files in the repo.. for .net would be the obj and bin folders for the docs it would be the dist folder and node_modules.
There was a problem hiding this comment.
README.md file is only used for the repo front page and NuGet (e.g. not run via docs). Could you please revert to the previous version?
There was a problem hiding this comment.
Is this file used for GitHub actions?
There was a problem hiding this comment.
no.. it is used to restore packages used in the docs.
There was a problem hiding this comment.
Is this file used for the GitHub actions?
There was a problem hiding this comment.
it keeps the version of each package used so in the cicd you are sure it install the especific versions.
2 participants
No description provided.