Skip to content

Add pagination args to trades #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexex10 merged 1 commit into from
Oct 31, 2025
Merged

Add pagination args to trades #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "x10-python-trading-starknet"
version = "0.0.14"
version = "0.0.15"
description = "Python client for X10 API"
authors = ["X10 <tech@ex10.org>"]
repository = "https://github.com/x10xchange/python_sdk"
Expand Down
4 changes: 3 additions & 1 deletion x10/perpetual/trading_client/account_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,16 @@ async def get_trades(
market_names: List[str],
trade_side: Optional[OrderSide] = None,
trade_type: Optional[TradeType] = None,
cursor: Optional[int] = None,
limit: Optional[int] = None,
) -> WrappedApiResponse[List[AccountTradeModel]]:
"""
https://api.docs.extended.exchange/#get-trades
"""

url = self._get_url(
"/user/trades",
query={"market": market_names, "side": trade_side, "type": trade_type},
query={"market": market_names, "side": trade_side, "type": trade_type, "cursor": cursor, "limit": limit},
)

return await send_get_request(
Expand Down