GlobalContributions: Highlight pending edits (FlaggedRevs extension)#531
Draft
agoujot wants to merge 19 commits intox-tools:mainfrom
Draft
GlobalContributions: Highlight pending edits (FlaggedRevs extension)#531agoujot wants to merge 19 commits intox-tools:mainfrom
agoujot wants to merge 19 commits intox-tools:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
============================================
- Coverage 71.30% 69.56% -1.75%
- Complexity 1275 1325 +50
============================================
Files 46 46
Lines 3792 3982 +190
============================================
+ Hits 2704 2770 +66
- Misses 1088 1212 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Oh hang on, this may have a problem: getting the extensions of 1 project is 1 api call. From quick testing, these api calls each take 0.3-08 seconds. Let's say average 0.5. That means, for someone that has edited 50 projects, or 5% of all projects, 50 seconds of waiting time. That's not good. |
Member
Author
|
Similarly to the fix for #568 , normally we should be able to check having or not flaggedrevs simply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are roughly:
Bug: T322466