Skip to content

修复throttle闭包导致的内存泄漏问题 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjxxcc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

修复throttle闭包导致的内存泄漏问题 #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8178359
修复throttle闭包导致的内存泄漏问题
pjxxcc Jun 30, 2022
300819f
Update throttle.js
pjxxcc Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions func/throttle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,20 @@
* @return {Function}
*/
function throttle (callback, wait, options) {
var args, context
var opts = options || {}
var runFlag = false
var timeout = 0
var optLeading = 'leading' in opts ? opts.leading : true
var optTrailing = 'trailing' in opts ? opts.trailing : false
var runFn = function () {
var runFn = function (args, context) {
runFlag = true
callback.apply(context, args)
timeout = setTimeout(endFn, wait)
}
var endFn = function () {
var endFn = function (args, context) {
timeout = 0
if (!runFlag && optTrailing === true) {
runFn()
runFn(args, context)
}
}
var cancelFn = function () {
Expand All @@ -32,14 +31,14 @@ function throttle (callback, wait, options) {
return rest
}
var throttled = function () {
args = arguments
context = this
const args = arguments
const context = this
runFlag = false
if (timeout === 0) {
if (optLeading === true) {
runFn()
runFn(args, context)
} else if (optTrailing === true) {
timeout = setTimeout(endFn, wait)
timeout = setTimeout(() => endFn(args, context), wait)
}
}
}
Expand Down