Extract shared grand total score helpers#663
Merged
Merged
Conversation
wyne
commented
Jun 17, 2026
wyne
force-pushed
the
codex/extract-score-helpers
branch
from
3cbc9d0 to
c2f5ff4
Compare
wyne
changed the title
Owner
Author
|
Addressed review comment: renamed the shared helper to grandTotalScore and updated callers/tests to match the current naming convention. Also rebased the PR onto main so the diff is isolated from codex/defer-swipe-score-commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note: the focused Jest run passed but emitted duplicate manual mock warnings from .claude/worktrees being visible to Jest.