Improve edit input replacement UX by wyne · Pull Request #656 · wyne/scorepad-react-native

wyne · 2026-06-14T02:32:51Z

Summary

make game title editing controlled with select-on-focus, done-submit, and native/platform clear affordances
let player names clear locally while editing without saving blanks, then restore the original name on blur/end editing
add focused tests for title/player clear, replacement, and restore behavior

Tests

npm run lint
npm run test -- EditGame.test.tsx EditPlayerScreen.test.tsx --runInBand --watchman=false --coverage=false

github-actions · 2026-06-14T02:34:05Z

Coverage after merging codex/native-input-ux into main will be

61.13%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
redux
GamesSlice.ts	54.09%	27.50%	56.52%	64.58%	101, 109, 131–133, 148, 167, 178, 185, 187, 190–192, 242, 256, 269, 278–279, 279, 279, 285, 285, 285–286, 288, 29, 290–291, 294, 294, 294, 294, 294–295, 298–299, 301, 303, 303, 303, 303, 303–304, 306, 306, 306, 308–309, 312, 312, 312, 314, 52, 63, 80, 85–86, 86, 86, 98–99, 99, 99
PlayersSlice.ts	89.90%	100%	87.50%	85.11%	103, 105, 33, 50–51, 68–69
SettingsSlice.ts	46.81%	25%	42.11%	54.17%	101, 104, 54, 57, 63, 66, 72, 75, 84, 84, 84, 90, 93, 98
backup.ts	0%	0%	0%	0%	11, 27–29, 31, 45–49, 51, 51, 51–52, 57, 60, 64–66, 71, 71, 71, 73–75, 78–79, 81–82, 85, 85, 85, 85, 85–87, 90–93, 95, 97
hooks.ts	100%	100%	100%	100%
selectors.ts	100%	100%	100%	100%
store.ts	0%	0%	0%	0%	10, 12, 12, 12–13, 13, 13–15, 18, 21–23, 23, 23, 23, 23–24, 28, 54, 61, 68, 75, 93
testStore.ts	0%	100%	0%	0%	11–15, 20–23, 25, 42–44, 5
src
Analytics.ts	100%	100%	100%	100%
ColorPalette.ts	100%	100%	100%	100%
Logger.ts	91.23%	87.50%	81.82%	94.74%	14–15, 22
Navigation.tsx	75.68%	72.73%	62.50%	83.33%	45, 49, 70, 73, 79–80
constants.ts	100%	100%	100%	100%
theme.ts	93.75%	85.71%	100%	100%	79
src/components
EditGame.tsx	79.63%	75%	66.67%	84.85%	35, 49, 62–63, 86, 86, 86–87
FloatingActionButton.tsx	68.97%	100%	50%	73.68%	38, 41–42, 55–56
GameListItem.tsx	66.10%	47.83%	100%	73.33%	103, 20, 23–24, 24, 24–26, 26, 26–28, 28, 28–30, 30, 30–31, 73
GameListItemPlayerName.tsx	100%	100%	100%	100%
MenuOpenContext.tsx	87.50%	100%	66.67%	100%
PlayerListItem.tsx	0%	0%	0%	0%	123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
ScoreLogTable.tsx	92.59%	82.35%	100%	96.15%	50, 52, 54, 54
SplashOverlay.tsx	0%	0%	0%	0%	22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
RotatingIcon.tsx	0%	0%	0%	0%	18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
SeedData.ts	0%	100%	0%	0%	17, 47, 49–50, 52, 54–56, 58–60, 62, 68, 71, 82–85
src/components/BigButtons
BigButton.tsx	0%	0%	0%	0%	18, 18–20, 22–23, 23, 25, 25–26, 26, 48
src/components/Boards
ListBoard.tsx	86.81%	72.73%	84.21%	98.57%	123, 180, 206–207, 220, 223, 262, 29, 33, 59–61, 84, 84, 88, 92
PlayerTile.tsx	0%	0%	0%	0%	29, 39, 39, 39, 39, 39–40, 40, 40, 40, 40, 42–46, 46, 46–47, 47, 47, 47, 47–48, 48, 48–50, 50, 50, 52–54, 54, 54, 56, 59, 59, 63–64, 67–68, 70, 80, 80, 97
TileBoard.tsx	96.39%	90.32%	100%	100%	18, 78, 92
src/components/Buttons
AppSettingsButton.tsx	100%	100%	100%	100%
BackButton.tsx	0%	100%	0%	0%	16–18, 20–21
GameOptionsButton.tsx	53.40%	45%	75%	54.90%	100, 118, 118, 118, 118, 118, 118, 118, 120–122, 124–126, 128–130, 132–135, 137–139, 141–143, 150, 156–157, 168, 170, 170, 176, 176, 176, 176, 38, 44, 46, 56, 63, 71, 92, 96
HeaderButton.tsx	100%	100%	100%	100%
src/components/ColorPalettes
ColorSelector.tsx	100%	100%	100%	100%
PalettePreview.tsx	0%	0%	0%	0%	10–12, 14, 19, 19, 25
PaletteSelector.tsx	0%	0%	0%	0%	13, 15–18, 20, 22, 22, 22, 24–25, 31, 37, 40, 45, 56
src/components/Headers
RoundHeaderTitle.tsx	0%	0%	0%	0%	12–14, 16, 18, 18, 18, 20–21, 21, 21–22, 22, 22, 24–25, 27–28, 28, 28, 28, 28, 30–31, 31, 34–35, 44–45, 45, 45, 47–49, 57, 59, 62, 62, 62, 62, 64, 64, 70, 70, 70, 70, 73, 73, 73, 73, 73, 75, 75, <

github-actions · 2026-06-14T02:40:17Z

Coverage after merging codex/native-input-ux into main will be

61.16%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
redux
GamesSlice.ts	54.09%	27.50%	56.52%	64.58%	101, 109, 131–133, 148, 167, 178, 185, 187, 190–192, 242, 256, 269, 278–279, 279, 279, 285, 285, 285–286, 288, 29, 290–291, 294, 294, 294, 294, 294–295, 298–299, 301, 303, 303, 303, 303, 303–304, 306, 306, 306, 308–309, 312, 312, 312, 314, 52, 63, 80, 85–86, 86, 86, 98–99, 99, 99
PlayersSlice.ts	89.91%	96.67%	88.46%	86.79%	103, 105, 113, 33, 50–51, 68–69
SettingsSlice.ts	46.81%	25%	42.11%	54.17%	101, 104, 54, 57, 63, 66, 72, 75, 84, 84, 84, 90, 93, 98
backup.ts	0%	0%	0%	0%	11, 27–29, 31, 45–49, 51, 51, 51–52, 57, 60, 64–66, 71, 71, 71, 73–75, 78–79, 81–82, 85, 85, 85, 85, 85–87, 90–93, 95, 97
hooks.ts	100%	100%	100%	100%
selectors.ts	100%	100%	100%	100%
store.ts	0%	0%	0%	0%	10, 12, 12, 12–13, 13, 13–15, 18, 21–23, 23, 23, 23, 23–24, 28, 54, 61, 68, 75, 93
testStore.ts	0%	100%	0%	0%	11–15, 20–23, 25, 42–44, 5
src
Analytics.ts	100%	100%	100%	100%
ColorPalette.ts	100%	100%	100%	100%
Logger.ts	91.23%	87.50%	81.82%	94.74%	14–15, 22
Navigation.tsx	75.68%	72.73%	62.50%	83.33%	45, 49, 70, 73, 79–80
constants.ts	100%	100%	100%	100%
theme.ts	93.75%	85.71%	100%	100%	79
src/components
EditGame.tsx	79.63%	75%	66.67%	84.85%	35, 49, 62–63, 86, 86, 86–87
FloatingActionButton.tsx	68.97%	100%	50%	73.68%	38, 41–42, 55–56
GameListItem.tsx	66.10%	47.83%	100%	73.33%	103, 20, 23–24, 24, 24–26, 26, 26–28, 28, 28–30, 30, 30–31, 73
GameListItemPlayerName.tsx	100%	100%	100%	100%
MenuOpenContext.tsx	87.50%	100%	66.67%	100%
PlayerListItem.tsx	0%	0%	0%	0%	123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
ScoreLogTable.tsx	92.59%	82.35%	100%	96.15%	50, 52, 54, 54
SplashOverlay.tsx	0%	0%	0%	0%	22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
RotatingIcon.tsx	0%	0%	0%	0%	18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
SeedData.ts	0%	100%	0%	0%	17, 47, 49–50, 52, 54–56, 58–60, 62, 68, 71, 82–85
src/components/BigButtons
BigButton.tsx	0%	0%	0%	0%	18, 18–20, 22–23, 23, 25, 25–26, 26, 48
src/components/Boards
ListBoard.tsx	86.81%	72.73%	84.21%	98.57%	123, 180, 206–207, 220, 223, 262, 29, 33, 59–61, 84, 84, 88, 92
PlayerTile.tsx	0%	0%	0%	0%	29, 39, 39, 39, 39, 39–40, 40, 40, 40, 40, 42–46, 46, 46–47, 47, 47, 47, 47–48, 48, 48–50, 50, 50, 52–54, 54, 54, 56, 59, 59, 63–64, 67–68, 70, 80, 80, 97
TileBoard.tsx	96.39%	90.32%	100%	100%	18, 78, 92
src/components/Buttons
AppSettingsButton.tsx	100%	100%	100%	100%
BackButton.tsx	0%	100%	0%	0%	16–18, 20–21
GameOptionsButton.tsx	53.40%	45%	75%	54.90%	100, 118, 118, 118, 118, 118, 118, 118, 120–122, 124–126, 128–130, 132–135, 137–139, 141–143, 150, 156–157, 168, 170, 170, 176, 176, 176, 176, 38, 44, 46, 56, 63, 71, 92, 96
HeaderButton.tsx	100%	100%	100%	100%
src/components/ColorPalettes
ColorSelector.tsx	100%	100%	100%	100%
PalettePreview.tsx	0%	0%	0%	0%	10–12, 14, 19, 19, 25
PaletteSelector.tsx	0%	0%	0%	0%	13, 15–18, 20, 22, 22, 22, 24–25, 31, 37, 40, 45, 56
src/components/Headers
RoundHeaderTitle.tsx	0%	0%	0%	0%	12–14, 16, 18, 18, 18, 20–21, 21, 21–22, 22, 22, 24–25, 27–28, 28, 28, 28, 28, 30–31, 31, 34–35, 44–45, 45, 45, 47–49, 57, 59, 62, 62, 62, 62, 64, 64, 70, 70, 70, 70, 73, 73, 73, 73, 73, 75,

github-actions · 2026-06-14T02:42:21Z

Coverage after merging codex/native-input-ux into main will be

61.45%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
redux
GamesSlice.ts	54.09%	27.50%	56.52%	64.58%	101, 109, 131–133, 148, 167, 178, 185, 187, 190–192, 242, 256, 269, 278–279, 279, 279, 285, 285, 285–286, 288, 29, 290–291, 294, 294, 294, 294, 294–295, 298–299, 301, 303, 303, 303, 303, 303–304, 306, 306, 306, 308–309, 312, 312, 312, 314, 52, 63, 80, 85–86, 86, 86, 98–99, 99, 99
PlayersSlice.ts	89.91%	96.67%	88.46%	86.79%	103, 105, 113, 33, 50–51, 68–69
SettingsSlice.ts	46.81%	25%	42.11%	54.17%	101, 104, 54, 57, 63, 66, 72, 75, 84, 84, 84, 90, 93, 98
backup.ts	0%	0%	0%	0%	11, 27–29, 31, 45–49, 51, 51, 51–52, 57, 60, 64–66, 71, 71, 71, 73–75, 78–79, 81–82, 85, 85, 85, 85, 85–87, 90–93, 95, 97
hooks.ts	100%	100%	100%	100%
selectors.ts	100%	100%	100%	100%
store.ts	0%	0%	0%	0%	10, 12, 12, 12–13, 13, 13–15, 18, 21–23, 23, 23, 23, 23–24, 28, 54, 61, 68, 75, 93
testStore.ts	0%	100%	0%	0%	11–15, 20–23, 25, 42–44, 5
src
Analytics.ts	100%	100%	100%	100%
ColorPalette.ts	100%	100%	100%	100%
Logger.ts	91.23%	87.50%	81.82%	94.74%	14–15, 22
Navigation.tsx	75.68%	72.73%	62.50%	83.33%	45, 49, 70, 73, 79–80
constants.ts	100%	100%	100%	100%
theme.ts	93.75%	85.71%	100%	100%	79
src/components
EditGame.tsx	79.63%	75%	66.67%	84.85%	35, 49, 62–63, 86, 86, 86–87
FloatingActionButton.tsx	68.97%	100%	50%	73.68%	38, 41–42, 55–56
GameListItem.tsx	66.10%	47.83%	100%	73.33%	103, 20, 23–24, 24, 24–26, 26, 26–28, 28, 28–30, 30, 30–31, 73
GameListItemPlayerName.tsx	100%	100%	100%	100%
MenuOpenContext.tsx	87.50%	100%	66.67%	100%
PlayerListItem.tsx	0%	0%	0%	0%	123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
ScoreLogTable.tsx	92.59%	82.35%	100%	96.15%	50, 52, 54, 54
SplashOverlay.tsx	0%	0%	0%	0%	22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
RotatingIcon.tsx	0%	0%	0%	0%	18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
SeedData.ts	0%	100%	0%	0%	17, 47, 49–50, 52, 54–56, 58–60, 62, 68, 71, 82–85
src/components/BigButtons
BigButton.tsx	0%	0%	0%	0%	18, 18–20, 22–23, 23, 25, 25–26, 26, 48
src/components/Boards
ListBoard.tsx	86.81%	72.73%	84.21%	98.57%	123, 180, 206–207, 220, 223, 262, 29, 33, 59–61, 84, 84, 88, 92
PlayerTile.tsx	0%	0%	0%	0%	29, 39, 39, 39, 39, 39–40, 40, 40, 40, 40, 42–46, 46, 46–47, 47, 47, 47, 47–48, 48, 48–50, 50, 50, 52–54, 54, 54, 56, 59, 59, 63–64, 67–68, 70, 80, 80, 97
TileBoard.tsx	96.39%	90.32%	100%	100%	18, 78, 92
src/components/Buttons
AppSettingsButton.tsx	100%	100%	100%	100%
BackButton.tsx	0%	100%	0%	0%	16–18, 20–21
GameOptionsButton.tsx	53.40%	45%	75%	54.90%	100, 118, 118, 118, 118, 118, 118, 118, 120–122, 124–126, 128–130, 132–135, 137–139, 141–143, 150, 156–157, 168, 170, 170, 176, 176, 176, 176, 38, 44, 46, 56, 63, 71, 92, 96
HeaderButton.tsx	100%	100%	100%	100%
src/components/ColorPalettes
ColorSelector.tsx	100%	100%	100%	100%
PalettePreview.tsx	0%	0%	0%	0%	10–12, 14, 19, 19, 25
PaletteSelector.tsx	0%	0%	0%	0%	13, 15–18, 20, 22, 22, 22, 24–25, 31, 37, 40, 45, 56
src/components/Headers
RoundHeaderTitle.tsx	0%	0%	0%	0%	12–14, 16, 18, 18, 18, 20–21, 21, 21–22, 22, 22, 24–25, 27–28, 28, 28, 28, 28, 30–31, 31, 34–35, 44–45, 45, 45, 47–49, 57, 59, 62, 62, 62, 62, 64, 64, 70, 70, 70, 70, 73, 73, 73, 73, 73, 75,

github-actions · 2026-06-14T02:52:11Z

Coverage after merging codex/native-input-ux into main will be

61.79%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
redux
GamesSlice.ts	54.72%	27.50%	56.52%	65.63%	101, 109, 131–133, 148, 167, 178, 185, 187, 190–192, 256, 269, 278–279, 279, 279, 285, 285, 285–286, 288, 29, 290–291, 294, 294, 294, 294, 294–295, 298–299, 301, 303, 303, 303, 303, 303–304, 306, 306, 306, 308–309, 312, 312, 312, 314, 52, 63, 80, 85–86, 86, 86, 98–99, 99, 99
PlayersSlice.ts	89.91%	96.67%	88.46%	86.79%	103, 105, 113, 33, 50–51, 68–69
SettingsSlice.ts	53.19%	50%	47.37%	58.33%	101, 104, 54, 57, 63, 66, 72, 75, 84, 90, 93, 98
backup.ts	0%	0%	0%	0%	11, 27–29, 31, 45–49, 51, 51, 51–52, 57, 60, 64–66, 71, 71, 71, 73–75, 78–79, 81–82, 85, 85, 85, 85, 85–87, 90–93, 95, 97
hooks.ts	100%	100%	100%	100%
selectors.ts	100%	100%	100%	100%
store.ts	0%	0%	0%	0%	10, 12, 12, 12–13, 13, 13–15, 18, 21–23, 23, 23, 23, 23–24, 28, 54, 61, 68, 75, 93
testStore.ts	0%	100%	0%	0%	11–15, 20–23, 25, 42–44, 5
src
Analytics.ts	100%	100%	100%	100%
ColorPalette.ts	100%	100%	100%	100%
Logger.ts	91.23%	87.50%	81.82%	94.74%	14–15, 22
Navigation.tsx	75.68%	72.73%	62.50%	83.33%	45, 49, 70, 73, 79–80
constants.ts	100%	100%	100%	100%
theme.ts	93.75%	85.71%	100%	100%	79
src/components
EditGame.tsx	79.63%	75%	66.67%	84.85%	35, 49, 62–63, 86, 86, 86–87
FloatingActionButton.tsx	93.75%	100%	88.89%	95.24%	42
GameListItem.tsx	66.10%	47.83%	100%	73.33%	103, 20, 23–24, 24, 24–26, 26, 26–28, 28, 28–30, 30, 30–31, 73
GameListItemPlayerName.tsx	100%	100%	100%	100%
MenuOpenContext.tsx	87.50%	100%	66.67%	100%
PlayerListItem.tsx	0%	0%	0%	0%	123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
ScoreLogTable.tsx	92.59%	82.35%	100%	96.15%	50, 52, 54, 54
SplashOverlay.tsx	0%	0%	0%	0%	22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
RotatingIcon.tsx	0%	0%	0%	0%	18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
SeedData.ts	0%	100%	0%	0%	17, 47, 49–50, 52, 54–56, 58–60, 62, 68, 71, 82–85
src/components/BigButtons
BigButton.tsx	0%	0%	0%	0%	18, 18–20, 22–23, 23, 25, 25–26, 26, 48
src/components/Boards
ListBoard.tsx	86.81%	72.73%	84.21%	98.57%	123, 180, 206–207, 220, 223, 262, 29, 33, 59–61, 84, 84, 88, 92
PlayerTile.tsx	0%	0%	0%	0%	29, 39, 39, 39, 39, 39–40, 40, 40, 40, 40, 42–46, 46, 46–47, 47, 47, 47, 47–48, 48, 48–50, 50, 50, 52–54, 54, 54, 56, 59, 59, 63–64, 67–68, 70, 80, 80, 97
TileBoard.tsx	96.39%	90.32%	100%	100%	18, 78, 92
src/components/Buttons
AppSettingsButton.tsx	100%	100%	100%	100%
BackButton.tsx	0%	100%	0%	0%	16–18, 20–21
GameOptionsButton.tsx	53.40%	45%	75%	54.90%	100, 118, 118, 118, 118, 118, 118, 118, 120–122, 124–126, 128–130, 132–135, 137–139, 141–143, 150, 156–157, 168, 170, 170, 176, 176, 176, 176, 38, 44, 46, 56, 63, 71, 92, 96
HeaderButton.tsx	100%	100%	100%	100%
src/components/ColorPalettes
ColorSelector.tsx	100%	100%	100%	100%
PalettePreview.tsx	0%	0%	0%	0%	10–12, 14, 19, 19, 25
PaletteSelector.tsx	0%	0%	0%	0%	13, 15–18, 20, 22, 22, 22, 24–25, 31, 37, 40, 45, 56
src/components/Headers
RoundHeaderTitle.tsx	0%	0%	0%	0%	12–14, 16, 18, 18, 18, 20–21, 21, 21–22, 22, 22, 24–25, 27–28, 28, 28, 28, 28, 30–31, 31, 34–35, 44–45, 45, 45, 47–49, 57, 59, 62, 62, 62, 62, 64, 64, 70, 70, 70, 70, 73, 73, 73, 73, 73, 75, 75, 75, 75, 84
src/components/Icons

Improve edit input replacement UX

0fb554f

Memoize player name suggestions selector

1ecebf7

Dismiss player name input on exit

6c4fa19

Dismiss keyboard when opening new game menu

36d3a26

wyne merged commit e436725 into main Jun 16, 2026
5 checks passed

wyne deleted the codex/native-input-ux branch June 16, 2026 03:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve edit input replacement UX#656

Improve edit input replacement UX#656
wyne merged 4 commits into
mainfrom
codex/native-input-ux

wyne commented Jun 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

wyne commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

wyne commented Jun 14, 2026 •

edited

Loading