feat: raise MAX_PLAYERS to 50, per-game interactionType#622
Open
wyne wants to merge 1 commit into
Open
Conversation
- MAX_PLAYERS: 20 → 50; add MAX_PLAYERS_FLEXBOX = 12 constant - Add interactionType?: InteractionType to GameState interface - Add setGameInteractionType reducer to GamesSlice - selectInteractionType now accepts optional gameId — checks game-level setting first, falls back to global SettingsSlice value - GameOptionsButton dispatches setGameInteractionType (per-game) instead of setInteractionType (global); reads type via updated selector - GameScreen, FlexboxTile, useGestureHint all pass currentGameId to selectInteractionType so they reflect per-game gesture choice - Update GameOptionsButton test store to include games reducer - Add selector tests for game-level override and fallback behavior Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_PLAYERSfrom 20 → 50; addsMAX_PLAYERS_FLEXBOX = 12constant (threshold above which Dial will be enforced, wired up in a follow-on PR)interactionType?: InteractionTypetoGameStateso each game can have its own gesture setting independent of the global defaultsetGameInteractionTypeRedux action toGamesSliceselectInteractionType(state, gameId?)to check the game-level setting first, falling back to the globalSettingsSlicevalueGameOptionsButtonnow dispatchessetGameInteractionType(per-game) instead of the globalsetInteractionType; reads gesture type via the updated selectorGameScreen,FlexboxTile, anduseGestureHintall passcurrentGameIdtoselectInteractionTypeTest plan
interactionTypeon the game entity)312 tests, 33 suites)🤖 Generated with Claude Code