Make session Load/Save provider-aware#7
Open
wydrox wants to merge 1 commit into
Open
Conversation
Remove the global sessionFile variable so that Load() and Save() correctly follow CurrentProvider() for both Frisco and Delio. SessionFilePath now derives paths deterministically from sessionDir, and tests exercise both provider-specific file writes and legacy fallback for Delio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionFileglobal soLoad()/Save()delegate toLoadProvider(CurrentProvider())/SaveProvider(CurrentProvider(), s)without an accidental Frisco-only path.SessionFilePathnow derives the frisco path directly fromsessionDir, keeping behavior identical for the default provider while ensuring Delio writes never accidentally land in the Frisco file.setTempProvidertest helper for isolatedcurrentProviderstate.Test plan
go vet ./...go test ./... -racego build -o bin/martmart ./cmd/martmart+./bin/martmart --help+./bin/martmart config show./bin/martmart --provider delio session showand--provider frisco session showeach read their own file;session from-curlwrites the correct{frisco,delio}-session.jsonunder~/.martmart-cli/.