Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the third-party github.com/mittwald/go-helm-client library with the official Helm v3 library (helm.sh/helm/v3). The refactor consolidates Kubernetes client initialization into a common utility function and updates all Helm operations to use the official APIs.
- Migrates from unofficial
go-helm-clientto officialhelm.sh/helm/v3library - Consolidates Kubernetes client initialization into a reusable
GetKubeClient()function - Updates all Helm operations (list, get, uninstall) to use official Helm action API
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/common/kube.go |
New file containing centralized Kubernetes client initialization |
internal/common/ciReleaseFunctions.go |
Updates Helm uninstall operations and adds failed release cleanup using official APIs |
go.mod |
Removes dependency on github.com/mittwald/go-helm-client |
cmd/ciScriptsEsInitRemove.go |
Replaces inline K8s client setup with common utility function |
cmd/ciReleaseWakeup.go |
Migrates Helm client initialization to official library |
cmd/ciReleaseList.go |
Updates release listing to use official Helm action API |
cmd/ciReleaseDiff.go |
Replaces inline K8s client setup with common utility function |
cmd/ciReleaseDeploy.go |
Updates K8s client initialization and replaces shell script with Go function |
cmd/ciReleaseDelete.go |
Migrates Helm client initialization and uninstall operations to official APIs |
cmd/ciReleaseCleanfailed.go |
Simplifies implementation by using new common cleanup function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bfea9ec to
8fa3678
Compare
8fa3678 to
51898f0
Compare
Rade333
suggested changes
Sep 8, 2025
Rade333
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces https://pkg.go.dev/github.com/mittwald/go-helm-client library with official helm library