Skip to content

Testing improvements milan#104

Open
toncic wants to merge 14 commits intomainfrom
testing-improvents-milan
Open

Testing improvements milan#104
toncic wants to merge 14 commits intomainfrom
testing-improvents-milan

Conversation

@toncic
Copy link
Copy Markdown

@toncic toncic commented Nov 19, 2021

Link to ticket: JIRA-123

Changes proposed in this PR:

  • change a
  • change b

How to test:

  1. do this
  2. then do that
  3. you should now see xyz

Link to feature environment:

Comment thread .circleci/config.yml

images:
- &node
image: circleci/node:12.16.1-browsers
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 16 LTS is out, I'd use that!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think circleci have deprecated these images in favour of convenience images (cimg). Here are the node ones:

https://circleci.com/developer/images/image/cimg/node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants