Skip to content

Patch package.json and package-lock.json#43

Closed
wu21-web wants to merge 4 commits into
mainfrom
deps-patch
Closed

Patch package.json and package-lock.json#43
wu21-web wants to merge 4 commits into
mainfrom
deps-patch

Conversation

@wu21-web

Copy link
Copy Markdown
Owner

This includes breaking changes.

@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
me-reader Error Error May 21, 2026 8:20am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the package.json file, specifically downgrading the Next.js dependency to version 9.3.3. The reviewer identified that this downgrade is incompatible with the project's use of React 19 and the App Router. Furthermore, the reviewer pointed out several other dependencies—including marked, node-cron, react, react-markdown, uuid, and eslint-config-next—that currently specify invalid or non-existent version numbers, which would lead to installation errors. Suggestions were provided to update these to stable, valid versions.

Comment thread package.json
"jszip": "^3.10.1",
"marked": "^17.0.4",
"multer": "^2.1.1",
"next": "^9.3.3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Downgrading next to ^9.3.3 is a critical issue. This project utilizes the App Router (app/ directory), next.config.ts, and React 19, all of which require Next.js 13+ (and v15 for React 19 support). Version 9 does not support these features and will break the application. Additionally, the previous version 16.2.6 does not exist. I recommend using a stable version like ^15.0.0 to ensure compatibility with React 19.

Suggested change
"next": "^9.3.3",
"next": "^15.0.0",

Comment thread package.json
"@sparticuz/chromium": "^143.0.4",
"highlight.js": "^11.11.1",
"jszip": "^3.10.1",
"marked": "^17.0.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version ^17.0.4 for marked appears to be invalid as the current major version is 15. This will cause installation errors.

Suggested change
"marked": "^17.0.4",
"marked": "^15.0.0",

Comment thread package.json
"marked": "^17.0.4",
"multer": "^2.1.1",
"next": "^9.3.3",
"node-cron": "^4.2.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version ^4.2.1 for node-cron appears to be invalid as the current major version is 3. This will cause installation errors.

Suggested change
"node-cron": "^4.2.1",
"node-cron": "^3.0.0",

Comment thread package.json
Comment on lines +20 to +21
"react": "19.2.3",
"react-dom": "19.2.3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 19.2.3 for react and react-dom appears to be invalid. The current stable version is 19.0.0.

Suggested change
"react": "19.2.3",
"react-dom": "19.2.3",
"react": "^19.0.0",
"react-dom": "^19.0.0",

Comment thread package.json
"puppeteer-core": "^24.39.0",
"react": "19.2.3",
"react-dom": "19.2.3",
"react-markdown": "^10.1.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version ^10.1.0 for react-markdown appears to be invalid as the current major version is 9.

Suggested change
"react-markdown": "^10.1.0",
"react-markdown": "^9.0.0",

Comment thread package.json
"remark-frontmatter": "^5.0.0",
"remark-gfm": "^4.0.1",
"sanitize-html": "^2.17.1",
"uuid": "^14.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version ^14.0.0 for uuid appears to be invalid as the current major version is 11. This will cause installation errors.

Suggested change
"uuid": "^14.0.0"
"uuid": "^11.0.0"

Comment thread package.json
"@types/sanitize-html": "^2.16.1",
"@types/uuid": "^10.0.0",
"eslint": "^9",
"eslint-config-next": "16.1.6",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 16.1.6 for eslint-config-next does not exist. This should match the major version of Next.js being used. If you upgrade to Next.js 15 as suggested, this should be updated to ^15.0.0.

Suggested change
"eslint-config-next": "16.1.6",
"eslint-config-next": "^15.0.0",

Repository owner locked as off-topic and limited conversation to collaborators May 21, 2026
@wu21-web wu21-web closed this May 21, 2026
@wu21-web wu21-web deleted the deps-patch branch May 21, 2026 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant