Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens wrapper scripts for the AEM Compose project by adding comprehensive error handling, retry logic, and validation. The changes also include a migration from Makefile to Taskfile for build automation and the addition of the Maven wrapper (mvnw) with Java vendoring support.
Changes:
- Enhanced shell wrapper scripts (taskw, aemw) with command validation, download retry logic with timeouts, and archive integrity checks
- Replaced Makefile with Taskfile-based build system split into CLI and AEM-specific task files
- Added Maven wrapper (mvnw) with automatic Java preparation and vendoring
- Added default environment configuration files and AEM instance configuration
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/project/common/taskw | Enhanced with command checks, retry logic, timeout handling, and archive validation |
| pkg/project/common/aemw | Enhanced with command checks, retry logic, timeout handling, and archive validation |
| mvnw | New Maven wrapper with Java vendoring and preparation logic |
| aemw | Simple wrapper script to invoke AEM CLI |
| local.env | Default environment variables for AEM instances |
| aem/default/etc/aem.yml | Comprehensive AEM instance configuration |
| Taskfile.yml | Main task configuration with environment variables and includes |
| Taskfile.cli.yml | CLI-related build tasks (test, build, release, etc.) |
| Taskfile.aem.yml | AEM-specific operational tasks (setup, provision, monitoring) |
| Makefile | Removed and replaced with Taskfile system |
| .mvn/wrapper/* | Maven wrapper support files |
| .gitignore | Updated to ignore AEM-specific directories and environment files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.