Skip to content

Add customizable AMR to the authenticators #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Eranda2001 wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add customizable AMR to the authenticators #850

Eranda2001 wants to merge 6 commits into from

Conversation

@Eranda2001
Copy link

@Eranda2001 Eranda2001 commented Feb 25, 2025 •
edited
Loading

Proposed Changes in this Pull Request

  • Bring First Class Support for Customizable AMR Values

Related Issues

Note
-Merge wso2/carbon-identity-framework#6598 before merging
-Merge wso2-extensions/identity-inbound-auth-oauth#2736 before merging

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Feb 27, 2025
Closed
Closed
@Eranda2001 Eranda2001 marked this pull request as draft March 12, 2025 05:44
shanggeeth
shanggeeth reviewed Mar 17, 2025
View reviewed changes
@Eranda2001 Eranda2001 changed the base branch from feature-amr to master March 25, 2025 06:03
KaveeshaPiumini
KaveeshaPiumini reviewed Mar 26, 2025
View reviewed changes
.../wso2/carbon/identity/api/server/authenticators/v1/model/SystemLocalAuthenticatorUpdate.java Outdated
}
return o.toString().replace("\n", "\n");
}
} No newline at end of file
Copy link
Contributor

@KaveeshaPiumini KaveeshaPiumini Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

KaveeshaPiumini
KaveeshaPiumini reviewed Mar 26, 2025
View reviewed changes
...arbon/identity/api/server/authenticators/v1/impl/LocalAuthenticatorConfigBuilderFactory.java
}

public static LocalAuthenticatorConfig buildSystemLocalAuthenticator(
SystemLocalAuthenticatorUpdate config, LocalAuthenticatorConfig existingConfig) {
Copy link
Contributor

@KaveeshaPiumini KaveeshaPiumini Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SystemLocalAuthenticatorUpdate config, LocalAuthenticatorConfig existingConfig) {
SystemLocalAuthenticatorUpdate config, LocalAuthenticatorConfig existingConfig) {

KD23243
KD23243 reviewed Apr 3, 2025
View reviewed changes
...v1/src/gen/java/org/wso2/carbon/identity/api/server/idp/v1/model/FederatedAuthenticator.java Outdated
this.endpoint = endpoint;
}


Copy link
Contributor

@KD23243 KD23243 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove these lines

KD23243
KD23243 reviewed Apr 3, 2025
View reviewed changes
...src/gen/java/org/wso2/carbon/identity/api/server/configs/v1/model/AuthenticatorListItem.java
public String getAmrValue() {
return amrValue;
}
public void setAmrValue(String amrValue) {
Copy link
Contributor

@KD23243 KD23243 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a line here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThaminduR ThaminduR ThaminduR left review comments

@KaveeshaPiumini KaveeshaPiumini KaveeshaPiumini left review comments

@KD23243 KD23243 KD23243 left review comments

+1 more reviewer

@shanggeeth shanggeeth shanggeeth left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ThaminduR ThaminduR

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Eranda2001 @CLAassistant @ThaminduR @shanggeeth @KaveeshaPiumini @KD23243