Removing update tool files#501
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughSummaryThis pull request removes platform-specific update tool artifacts from multiple Dockerfiles across the WSO2 Identity Server Docker images. The changes affect 9 Dockerfiles with base images including Alpine, Rocky, Ubuntu, and variations with JDK 11/17 and post-quantum cryptography support. ChangesEach Dockerfile now includes a cleanup step that removes the following files from
The cleanup is performed as part of the existing server installation RUN instruction, before additional build steps such as ownership changes and artifact cleanup. ImpactThese changes reduce the final Docker image size by removing unnecessary platform-specific files that are not required in the containerized Linux environment. Each Dockerfile modification adds 4 lines to implement the cleanup. Files modified: 9 Dockerfiles
WalkthroughThis PR removes platform-specific update and setup artifacts from the WSO2 IS Docker images across nine Dockerfile variants. During the WSO2 server installation phase, each Dockerfile now deletes the Darwin ( 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request updates the Dockerfiles for multiple base images to remove unnecessary platform-specific update tool binaries and scripts after extracting the WSO2 server distribution. This helps reduce image size and eliminates files not needed in the containerized Linux environment.
The most important changes are:
Removal of unnecessary update tool binaries and scripts:
wso2update_darwin_*,wso2update_windows_*,update_tool_setup.ps1, andupdate_tool_setup.shfrom the${WSO2_SERVER_HOME}/bin/directory after unzipping the WSO2 server package. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]These changes ensure that only the necessary files for the Linux environment remain in the final Docker images, improving security and efficiency.