Skip to content

Removing update tool files#501

Open
indeewari wants to merge 1 commit into
wso2:masterfrom
indeewari:removing_update_tool
Open

Removing update tool files#501
indeewari wants to merge 1 commit into
wso2:masterfrom
indeewari:removing_update_tool

Conversation

@indeewari
Copy link
Copy Markdown

This pull request updates the Dockerfiles for multiple base images to remove unnecessary platform-specific update tool binaries and scripts after extracting the WSO2 server distribution. This helps reduce image size and eliminates files not needed in the containerized Linux environment.

The most important changes are:

Removal of unnecessary update tool binaries and scripts:

  • All affected Dockerfiles now remove wso2update_darwin_*, wso2update_windows_*, update_tool_setup.ps1, and update_tool_setup.sh from the ${WSO2_SERVER_HOME}/bin/ directory after unzipping the WSO2 server package. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

These changes ensure that only the necessary files for the Linux environment remain in the final Docker images, improving security and efficiency.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43ab6e49-0c7a-40bd-8bb5-0f3347f89410

📥 Commits

Reviewing files that changed from the base of the PR and between 1b64d9e and 024ba66.

📒 Files selected for processing (10)
  • dockerfiles/alpine/is/Dockerfile
  • dockerfiles/jdk11/alpine/is/Dockerfile
  • dockerfiles/jdk11/rocky/is/Dockerfile
  • dockerfiles/jdk11/ubuntu/is/Dockerfile
  • dockerfiles/jdk17/alpine/is/Dockerfile
  • dockerfiles/jdk17/rocky/is/Dockerfile
  • dockerfiles/jdk17/ubuntu/is/Dockerfile
  • dockerfiles/pqc/is/Dockerfile
  • dockerfiles/rocky/is/Dockerfile
  • dockerfiles/ubuntu/is/Dockerfile

📝 Walkthrough

Summary

This pull request removes platform-specific update tool artifacts from multiple Dockerfiles across the WSO2 Identity Server Docker images. The changes affect 9 Dockerfiles with base images including Alpine, Rocky, Ubuntu, and variations with JDK 11/17 and post-quantum cryptography support.

Changes

Each Dockerfile now includes a cleanup step that removes the following files from ${WSO2_SERVER_HOME}/bin/ after extracting the WSO2 server distribution:

  • wso2update_darwin_* (macOS-specific update tool binaries)
  • wso2update_windows_* (Windows-specific update tool binaries)
  • update_tool_setup.ps1 (PowerShell update tool setup script)
  • update_tool_setup.sh (shell update tool setup script)

The cleanup is performed as part of the existing server installation RUN instruction, before additional build steps such as ownership changes and artifact cleanup.

Impact

These changes reduce the final Docker image size by removing unnecessary platform-specific files that are not required in the containerized Linux environment. Each Dockerfile modification adds 4 lines to implement the cleanup.

Files modified: 9 Dockerfiles

  • dockerfiles/alpine/is/Dockerfile
  • dockerfiles/jdk11/alpine/is/Dockerfile
  • dockerfiles/jdk11/rocky/is/Dockerfile
  • dockerfiles/jdk11/ubuntu/is/Dockerfile
  • dockerfiles/jdk17/alpine/is/Dockerfile
  • dockerfiles/jdk17/rocky/is/Dockerfile
  • dockerfiles/jdk17/ubuntu/is/Dockerfile
  • dockerfiles/pqc/is/Dockerfile
  • dockerfiles/rocky/is/Dockerfile
  • dockerfiles/ubuntu/is/Dockerfile

Walkthrough

This PR removes platform-specific update and setup artifacts from the WSO2 IS Docker images across nine Dockerfile variants. During the WSO2 server installation phase, each Dockerfile now deletes the Darwin (wso2update_darwin_*), Windows (wso2update_windows_*) updater binaries and both PowerShell and shell setup scripts (update_tool_setup.ps1 and update_tool_setup.sh) from ${WSO2_SERVER_HOME}/bin. The cleanup is applied consistently across all base image and JDK combinations without altering the build logic or dependencies.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description clearly explains the purpose, changes, and benefits, but does not follow the repository's required template structure with sections like Goals, Approach, User stories, Release notes, etc. Restructure the description to follow the repository template, including Purpose, Goals, Approach, User stories, Release notes, Documentation, and other required sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Removing update tool files' directly and specifically describes the primary change across all modified Dockerfiles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@indeewari indeewari requested a review from ayeshajay May 19, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants