Add execute permission to docker-entrypoint.sh#464
Open
sahandilshan wants to merge 1 commit intowso2:7.1.xfrom
Open
Add execute permission to docker-entrypoint.sh#464sahandilshan wants to merge 1 commit intowso2:7.1.xfrom
sahandilshan wants to merge 1 commit intowso2:7.1.xfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds execute permissions to the entrypoint script so the container can start without permission errors.
- Adds a comment and a
chmod +xcommand fordocker-entrypoint.sh - Ensures the entrypoint is executable before the
ENTRYPOINTinstruction
| EXPOSE 4000 9763 9443 | ||
|
|
||
| # Provide execute permissions to docker-entrypoint.sh | ||
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh |
There was a problem hiding this comment.
[nitpick] Consider using COPY --chmod=+x when adding docker-entrypoint.sh earlier in the Dockerfile to set its permissions in the same layer and simplify the build.
Suggested change
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh | |
| # (Permissions are now set during the COPY operation above.) |
| EXPOSE 4000 9763 9443 | ||
|
|
||
| # Provide execute permissions to docker-entrypoint.sh | ||
| RUN chmod +x /home/wso2carbon/docker-entrypoint.sh |
There was a problem hiding this comment.
[nitpick] You could combine this RUN chmod +x with adjacent RUN commands to reduce the total number of layers and improve build efficiency.
AnuradhaSK
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #463