Skip to content

fix(core): 🐛 fix style related to coreRequestProgressBar #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PritamBag wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix(core): 🐛 fix style related to coreRequestProgressBar #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions package/components/feedback/CoreRequestProgressBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,19 @@ import { useSelector } from "react-redux";

import CoreLinearProgress from "./CoreLinearProgress";
import CoreClasses from "../../styles/CoreClasses";
import { sanitizeComponentProps } from "../../utils/componentUtil";
import CoreBox from "../layouts/CoreBox";
export default function CoreRequestProgressBar() {
export default function CoreRequestProgressBar(props) {
Copy link

Copilot AI Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider defining default prop values for styleClasses (for example, using defaultProps or default parameters) to ensure consistent styling when the component is used without explicitly passing styleClasses.

Suggested change
export default function CoreRequestProgressBar(props) {
export default function CoreRequestProgressBar(props = { styleClasses: [] }) {

Copilot uses AI. Check for mistakes.
const COLOR_PRIMARY = "primary";
const { requestProgress } = useSelector((state) => state?.app);

props = sanitizeComponentProps(CoreRequestProgressBar, props);

return (
<CoreBox
styleClasses={[CoreClasses.REQUEST_PROGRESS_BAR]}
>
<CoreBox {...props}>
<CoreLinearProgress color={COLOR_PRIMARY} styleClasses={requestProgress.visible ? [] : [CoreClasses.DISPLAY.NONE]} />
</CoreBox>
);
}
CoreRequestProgressBar.validProps = [];
CoreRequestProgressBar.invalidProps = [];
2 changes: 1 addition & 1 deletion package/components/layouts/_system/AppBuilderContainerLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default function AppBuilderContainerLayout() {
footer={getFooter}
coreClasses={CoreClasses}
>
<CoreRequestProgressBar />
<CoreRequestProgressBar styleClasses={[CoreClasses.REQUEST_PROGRESS_BAR]} />

<CoreBox styleClasses={[CoreClasses.LAYOUT.MAIN_CONTAINER]}>
<CoreLayoutPlaceholder
Expand Down
2 changes: 1 addition & 1 deletion package/components/layouts/_system/AppContainerLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default function AppContainerLayout() {
footer={getFooter}
coreClasses={CoreClasses}
>
<CoreRequestProgressBar />
<CoreRequestProgressBar styleClasses={[CoreClasses.REQUEST_PROGRESS_BAR]}/>

<CoreBox styleClasses={[CoreClasses.LAYOUT.MAIN_CONTAINER]}>
<CoreLayoutPlaceholder id={AppContainerLayout.PLACEHOLDER.CONTENT} />
Expand Down
Loading