Skip to content

fix(core): 🐛 notificationpopover is design is completed properly #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arkaprota wants to merge 8 commits into
base: development
Choose a base branch
from
Open

fix(core): 🐛 notificationpopover is design is completed properly #374

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3732636
fix(core): :bug: notificationpopover is design is completed properly
arkaprota Sep 17, 2024
3ed7286
Merge branch 'development' into WRPD-bugfix-373
techoneel Sep 21, 2024
a4885b6
fix(global): :bug: change the coreicon more_horiz to clear_all which …
arkaprota Sep 23, 2024
f38ef5d
Merge branch 'development' of https://github.com/wrappid/core into WR…
arkaprota Sep 23, 2024
da939ee
Merge branch 'WRPD-bugfix-373' of https://github.com/wrappid/core int…
arkaprota Sep 23, 2024
8b58b95
Merge branch 'development' into WRPD-bugfix-373
arkaprota Oct 14, 2024
820210e
Merge branch 'development' into WRPD-bugfix-373
arkaprota Oct 22, 2024
45a8b89
fix(core): :bug: remove the sx
arkaprota Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package/components/utils/NotificationPopOver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,22 @@ export default function NotificationPopOver() {
<>
<CoreBox styleClasses={[CoreClasses.POPOVER.CONTENT]}>
<CoreBox
styleClasses={[CoreClasses?.FLEX?.DIRECTION_ROW, CoreClasses.ALIGNMENT.JUSTIFY_CONTENT_SPACE_BETWEEN, CoreClasses.LAYOUT.VERTICAL_CENTER]}
styleClasses={[CoreClasses.DISPLAY.FLEX, CoreClasses.ALIGNMENT.JUSTIFY_CONTENT_SPACE_BETWEEN, CoreClasses.ALIGNMENT.ALIGN_ITEMS_CENTER]}
>
<CoreTypographyBody1>Notifications</CoreTypographyBody1>
<CoreTypographyBody1 styleClasses={[CoreClasses.MARGIN.MB0]}>Notifications</CoreTypographyBody1>

<CoreIconButton disabled>
<CoreIcon>clear_all</CoreIcon>
</CoreIconButton>
</CoreBox>

<CoreDivider />
</CoreBox>

<CoreDivider styleClasses={[CoreClasses.MARGIN.M0]}/>

<CoreBox styleClasses={[CoreClasses.POPOVER.CONTENT]}>
<CoreTypographyBody1
sx={{ minWidth: "350px" }}
minWidth={350}
styleClasses={[CoreClasses.MARGIN.MY4, CoreClasses.PADDING.PX5]}
>
No new notifications
Expand Down