Categories view mode#1762
Open
mihaijoldis wants to merge 1 commit intowp-e-commerce:masterfrom
mihaijoldis:patch-3
Open
Categories view mode#1762mihaijoldis wants to merge 1 commit intowp-e-commerce:masterfrom mihaijoldis:patch-3
mihaijoldis wants to merge 1 commit intowp-e-commerce:masterfrom
mihaijoldis:patch-3
Conversation
Fixes display type for categories overwriting the Presentation settings when selecting Default as option
Member
|
Is there an issue on Github for this PR? |
Member
|
#1505 perhaps? |
Author
|
Even after using the code change above SOME of the categories might have the display_type set in the meta table. To make sure the code change above will work correctly for existing categories that already have that in the DB i ran a sql query to remove all meta for existing categories that used the DEFAUL view mode: |
Member
|
Sounds like we need an upgrade routine here before we can merge. |
Member
|
Just remembered this PR existed :) A couple things, if we want to land #1505 in 4.0
|
Member
|
Punting this to 4.1, pending the required changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes display type for categories overwriting the Presentation settings when selecting Default as option