Skip to content

Catch exceptions in REPL to preserve session state on errors #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Catch exceptions in REPL to preserve session state on errors #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbd4f3d
Initial plan
Copilot Feb 4, 2026
4fcf188
Add exception handling to REPL to prevent session crashes
Copilot Feb 4, 2026
a234f7c
Improve error message format for better user experience
Copilot Feb 4, 2026
c62bc6b
Update features/shell.feature
swissspidy Feb 4, 2026
6a4f313
Fix test failures: use 'try' instead of 'run' for STDERR output
Copilot Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions features/shell.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,41 @@ Feature: WordPress REPL
"""
history: -1: invalid option
"""

Scenario: Exception handling preserves session state
Given a WP install
And a session file:
"""
$foo = 'test_value';
require 'nonexistent_file.txt';
echo $foo;
"""

When I try `wp shell --basic < session`
Then STDOUT should contain:
"""
test_value
"""
And STDERR should contain:
"""
Error: Failed opening required 'nonexistent_file.txt'
"""

Scenario: Exception handling for expression errors
Given a WP install
And a session file:
"""
$bar = 'preserved';
nonexistent_function();
$bar;
"""

When I try `wp shell --basic < session`
Then STDOUT should contain:
"""
string(9) "preserved"
"""
And STDERR should contain:
"""
Error: Call to undefined function nonexistent_function()
"""
19 changes: 15 additions & 4 deletions src/WP_CLI/Shell/REPL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ public function start() {

if ( self::starts_with( self::non_expressions(), $line ) ) {
ob_start();
// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
eval( $line );
try {
// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
eval( $line );
} catch ( \Throwable $e ) {
// Display the error message but continue the session
fwrite( STDERR, get_class( $e ) . ': ' . $e->getMessage() . "\n" );
}
$out = (string) ob_get_clean();
if ( 0 < strlen( $out ) ) {
$out = rtrim( $out, "\n" ) . "\n";
Expand All @@ -43,8 +48,14 @@ public function start() {

// Write directly to STDOUT, to sidestep any output buffers created by plugins
ob_start();
// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
$evl = eval( $line );
try {
// phpcs:ignore Squiz.PHP.Eval.Discouraged -- This is meant to be a REPL, no way to avoid eval.
$evl = eval( $line );
} catch ( \Throwable $e ) {
// Display the error message but continue the session
fwrite( STDERR, get_class( $e ) . ': ' . $e->getMessage() . "\n" );
$evl = null;
}
$out = (string) ob_get_clean();
if ( 0 < strlen( $out ) ) {
echo rtrim( $out, "\n" ) . "\n";
Expand Down
Loading