Skip to content

Rename classes to match underscores convention#1

Merged
swissspidy merged 1 commit into
mainfrom
fix/rename-classes-to-use-underscores
Dec 9, 2025
Merged

Rename classes to match underscores convention#1
swissspidy merged 1 commit into
mainfrom
fix/rename-classes-to-use-underscores

Conversation

@schlessera

Copy link
Copy Markdown
Member

Rename classes:

  • WP_CLI\Ability\AbilityCommand => WP_CLI\Ability\Ability_Command
  • WP_CLI\Ability\AbilityCategoryCommand => WP_CLI\Ability\Ability_Category_Command

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @schlessera, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors two core classes, AbilityCommand and AbilityCategoryCommand, by renaming them to Ability_Command and Ability_Category_Command respectively. The primary goal is to standardize class naming by adopting an underscore convention. This change involves updating the class declarations, renaming the corresponding PHP files, and modifying all instances where these classes are referenced, particularly within the command registration logic, to maintain functional integrity.

Highlights

  • Class Renaming: Renamed the WP_CLI\Ability\AbilityCommand class to WP_CLI\Ability\Ability_Command to align with an underscore naming convention.
  • Class Renaming: Renamed the WP_CLI\Ability\AbilityCategoryCommand class to WP_CLI\Ability\Ability_Category_Command to align with an underscore naming convention.
  • File Renaming: Renamed src/AbilityCommand.php to src/Ability_Command.php and src/AbilityCategoryCommand.php to src/Ability_Category_Command.php to match the new class names.
  • Command Registration Update: Updated the WP_CLI::add_command calls in ability-command.php to reference the newly named classes, ensuring proper command registration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@schlessera schlessera added this to the v1.0.0 milestone Dec 9, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly renames AbilityCommand and AbilityCategoryCommand to Ability_Command and Ability_Category_Command respectively, aligning them with the project's underscore-based naming convention. The changes have been consistently applied to the class definitions, filenames, and the WP_CLI::add_command registrations. This is a good refactoring that improves code consistency within the project.

@schlessera schlessera added enhancement New feature or request command:ability Related to 'ability' command command:ability-category Related to 'ability category' command labels Dec 9, 2025
@codecov

codecov Bot commented Dec 9, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@swissspidy swissspidy merged commit 45acddb into main Dec 9, 2025
45 checks passed
@swissspidy swissspidy deleted the fix/rename-classes-to-use-underscores branch December 9, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:ability Related to 'ability' command command:ability-category Related to 'ability category' command enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants