Update SourceTypeEnum in CollectableSourceInfo #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Field_10_1_5_49516_002 with SourceTypeEnum to clarify the source type of collectable entries.
There was a problem hiding this comment.
Pull request overview
This PR renames an unclear field name Field_10_1_5_49516_002 to the more descriptive SourceTypeEnum in the CollectableSourceInfo database definition and adds documentation explaining its purpose. The field indicates which CollectableSource table (Encounter, Quest, or Vendor) contains additional information about a collectable item's source.
- Renamed
Field_10_1_5_49516_002toSourceTypeEnumacross all layout definitions - Added documentation clarifying that the enum maps to different CollectableSource tables: 1 for Encounter, 2 for Quest, and 3 for Vendor
- Removed outdated reference to TransmogSourceTypeEnum which was from a different table
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It seems like Field_10_1_5_49516_002 from the dbc relates to the source of the item so you can look up the value in the correct table.
There are 3 tables so the max is 3, I expect if other tables start to exist for the number to increase. If a decor or appearance is obtained from different sources, we will have multiple entries with same or different enum value