Make the widget runnable as a browser demo.#15
Open
trangtinkers wants to merge 1 commit into
Open
Conversation
Dashboard was retired in macOS Catalina, so add a small window.widget shim (localStorage-backed preferences, window.open for openURL) so the widget can run from a plain HTTP server. Replace the hardcoded (8, 31) chrome/titlebar offset in getCoordsFromEvent with canvas.getBoundingClientRect()-based math. Without this, clicks land 8px left of where the map-pin hit test expects, and the 24px hit radius means drags frequently miss. The new math also divides out any CSS transform: scale() on the body so drags work under arbitrary scaling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard was retired in macOS Catalina, so add a small window.widget shim (localStorage-backed preferences, window.open for openURL) so the widget can run from a plain HTTP server.
Replace the hardcoded (8, 31) chrome/titlebar offset in getCoordsFromEvent with canvas.getBoundingClientRect()-based math. Without this, clicks land 8px left of where the map-pin hit test expects, and the 24px hit radius means drags frequently miss. The new math also divides out any CSS transform: scale() on the body so drags work under arbitrary scaling.