feat(draw): add fillStyle support for shapes#1137
Open
Kripu77 wants to merge 1 commit intoworktile:developfrom
Open
feat(draw): add fillStyle support for shapes#1137Kripu77 wants to merge 1 commit intoworktile:developfrom
Kripu77 wants to merge 1 commit intoworktile:developfrom
Conversation
|
@Kripu77 is attempting to deploy a commit to the tethys Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@pubuzhixing8 could you review this please? |
Collaborator
I would review it soon. |
pubuzhixing8
reviewed
Mar 6, 2026
| board = createTestingBoard([withDraw], []); | ||
| }); | ||
|
|
||
| describe('PlaitCommonGeometry interface', () => { |
Collaborator
There was a problem hiding this comment.
The unit tests do not verify any business logic
| const result = drawGeometry(board, rectangle, BasicShapes.rectangle, roughOptions); | ||
|
|
||
| expect(result).toBeDefined(); | ||
| expect(result instanceof SVGGElement).toBe(true); |
Collaborator
There was a problem hiding this comment.
Should we verify whether the result include hachure style?
Collaborator
|
@Kripu77 Could you add some functional examples for this feature, such as the mark of below image: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This allows shapes to render using any
rough.jssupported fill pattern instead of defaulting to solid.