Fix D1 migration script statement parsing and idempotency#5
Merged
Conversation
- Fix comment filtering to strip SQL comment lines from within statements instead of discarding entire chunks that start with '--'. This was causing the CREATE TABLE recordings statement to be filtered out when preceded by header comments, breaking foreign key references. - Make migration recording idempotent with INSERT OR IGNORE so migrations can be safely re-applied without unique constraint errors. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in the migration runner that were preventing D1 database migrations from completing:
Statement parsing bug: The comment filter was discarding entire statement chunks that started with
--, including the CREATE TABLE recordings statement which was preceded by header comments. This caused all dependent tables to fail due to missing foreign key references.Idempotency: The INSERT into _migrations wasn't idempotent, causing unique constraint errors when migrations were re-applied.
The fixes make both the statement parsing robust to comments and the migration recording safe for re-application.