Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .last-synced-sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1f87238ce12a3a940bf5e9eefe4276d32a1f2565
38a09d011329884c1be01721e2f513fd9c1ad742
14 changes: 0 additions & 14 deletions spec/open-api-spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24011,20 +24011,6 @@ components:
connections this is the ACS URL; for OIDC connections this is the
redirect URI.
example: https://auth.workos.com/sso/saml/acs/conn_externalkey
options:
type: object
properties:
signing_cert:
type:
- string
- 'null'
description: The signing certificate of the SAML connection.
example: null
required:
- signing_cert
description: >-
Configuration options for SAML connections. Only present for SAML
connection types.
created_at:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Preserve connection options
Removing Connection.options is a breaking schema change for generated clients that currently read SAML options.signing_cert; the PR's diff report flags this as a breaking removal. If the upstream API still returns this field, clients generated from this spec will drop access to an existing response property instead of modeling it as deprecated or nullable.

Artifacts

Repro: base and head Connection.options.signing_cert contract comparison script

  • Contains supporting evidence from the run (text/javascript; charset=utf-8).

Repro: contract comparison output showing base-present and head-missing options.signing_cert

  • Keeps the command output available without making the summary code-heavy.

Repro: repository OpenAPI sdk check output on head schema

  • Keeps the command output available without making the summary code-heavy.

View artifacts

T-Rex Ran code and verified through T-Rex

Prompt To Fix With AI
This is a comment left during a code review.
Path: spec/open-api-spec.yaml
Line: 24014

Comment:
**Preserve connection options**
Removing `Connection.options` is a breaking schema change for generated clients that currently read SAML `options.signing_cert`; the PR's diff report flags this as a breaking removal. If the upstream API still returns this field, clients generated from this spec will drop access to an existing response property instead of modeling it as deprecated or nullable.

How can I resolve this? If you propose a fix, please make it concise.

format: date-time
type: string
Expand Down
Loading