Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR alters the activation workflow so that when no editors are open, the welcome walkthrough is shown instead of an untitled file. Otherwise, existing behavior for revealing or creating the webview panel remains unchanged.
- Replace
newUntitledFilewithopenWalkthroughwhen no editors are open - Guard the walkthrough command behind an editor-count check
- Reorder imports in
extension.ts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
open-webview.ts |
Conditional launch of welcome walkthrough instead of new file |
extension.ts |
Alphabetized import statements and grouping of type imports |
Comments suppressed due to low confidence (1)
frontend/src/commands/functions/open-webview.ts:9
- Add tests to cover both scenarios: when there are open editors (including untitled) and when there are none, to verify the walkthrough is shown only in the no-editors case.
if (vscode.window.visibleTextEditors.length === 0) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
目的
毎回タイトル未定のファイルが開かれるのはウザイ
やったこと
動作確認
けいすけに直接見せる