docs: Clarify the use of Gutenberg and Gutenberg Mobile repository names#6527
Merged
Conversation
fluiddot
reviewed
Jan 10, 2024
Attempt to mitigate confusion between the `gutenberg` and `gutenberg-mobile` repositories, in addition to the general "Gutenberg" project and plugin.
It is better to describe the current state, rather than an ideal.
Member
|
I updated the PR to rely upon code repository names to be as explicit as possible during this period where we do not necessarily have a clear and consistently used project name to described the mobile variant of the block editor and differences between the two repositories. |
fluiddot
approved these changes
Jan 10, 2024
Contributor
fluiddot
left a comment
fluiddot
left a comment
There was a problem hiding this comment.
LGTM 🎊 ! Thanks @dcalhoun for updating the documentation 🙇 !
I noticed that some of the CI checks are failing. The error is the same we encountered yesterday related to Buildkite not being able to checkout the Gutenberg repository (#6520 (comment)). This is already fixed in trunk (#6525), so I'd recommend updating the branch with the latest changes.
…into docs/clarify-e2e-test-repo-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the references to Gutenberg and Gutenberg Mobile repositories in E2E testing docs.
@dcalhoun in the context of previous changes in 4574af6, please verify if the intent in this PR is correct, and feel free to make and changes or suggestions directly.
PR submission checklist: