Migrate to scene-based lifecyle#25628
Open
crazytonyli wants to merge 10 commits into
Open
Conversation
NoticePresenter sizes its window from UIApplication.shared.mainWindow, which under the scene life cycle does not exist until the main window becomes key in showInitialUI. Creating it in didFinishLaunching gave it a zero frame.
AppAppearance.overrideAppearance() and the Home Screen quick action creation both reach the app's window indirectly (the override style target and the 3D Touch trait check). Under the scene life cycle the window does not exist until the scene connects, so these no-opped when left in willFinishLaunching and runStartupSequence. Move them into showInitialUI alongside the other window-dependent launch steps.
UntouchableWindow was created with init(frame:), which leaves it without a windowScene. Such a window does not display (or attaches to the wrong scene) under the UIScene life cycle. Add a windowScene initializer and use it in NoticePresenter when the main window's scene is available.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32479 | |
| Version | PR #25628 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | eef3ea4 | |
| Installation URL | 6bbog6vmv76eo |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32479 | |
| Version | PR #25628 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | eef3ea4 | |
| Installation URL | 1fmvjdc0v04a8 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
The app Info.plist now declares a UIApplicationSceneManifest, so the unit test host (WordPress.app running TestingAppDelegate) adopts the scene life cycle but never connects a window scene. UIApplication.mainWindow resolves the connected scene's key window, which is therefore nil, breaking tests that read it (RichContentFormatter directly, QRLogin and others via leafViewController). Fall back to the app delegate's window in the test bundle's mainWindow override, and expose TestingAppDelegate.window via @objc so the fallback can read it.
jkmassel
requested changes
Jun 10, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
The bot is concerned about CompliancePopoverCoordinator.presentPopover() not working and handleWillEnterForeground() being called more than once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I recommend reviewing by commit. The first commit is swift-format code changes.
Description
This is a blocker to compiling on Xcode 27. The migration is required by Xcode 27.
https://developer.apple.com/documentation/technotes/tn3187-migrating-to-the-uikit-scene-based-life-cycle