Skip to content

Remove check for modified main strings.xml outside release branch #22382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iangmaia merged 1 commit into from
Dec 8, 2025
Merged

Remove check for modified main strings.xml outside release branch #22382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Dangerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ end

common_release_checker.check_internal_release_notes_changed(report_type: :message)

android_release_checker.check_modified_strings_on_release
Copy link
Contributor

@iangmaia iangmaia Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #20132, I've noticed in the description:

Added check for translations being changed only on the release branch

Which I think makes sense on WPAndroid?
Though there seems to be a bug in the check itself as it's checking any strings.xml, including the base, and not only the translations. Probably it comes from my misunderstanding of the strings sync process back then.

I've created Automattic/dangermattic#105 to tackle this issue separately to eventually use this check.


view_changes_checker.check

pr_size_checker.check_diff_size(
Expand Down