[Gutenberg] Test persisting local media files when uploading images by derekblank · Pull Request #19963 · wordpress-mobile/WordPress-Android

derekblank · 2024-01-17T09:08:35Z

Test build to persist local media file without flicker between downloading a server image asset.

[RNMobile] Update Image component to avoid flicker when updating the URI WordPress/gutenberg#57869
Update Image component to avoid flicker when updating the URI gutenberg-mobile#6550

Fixes:

Prevent editor image uploads from temporarily disappearing when upload is completed gutenberg-mobile#6510

Regression Notes

Potential unintended areas of impact
- TODO
What I did to test those areas of impact (or what existing automated tests I relied on)
- TODO
What automated tests I added (or what prevented me from doing so)
- TODO

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot · 2024-01-17T11:50:42Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19963-943b70f
	Commit	`943b70f`
	Direct Download	`wordpress-prototype-build-pr19963-943b70f.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-01-17T11:51:30Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19963-943b70f
	Commit	`943b70f`
	Direct Download	`jetpack-prototype-build-pr19963-943b70f.apk`

Note: Google Login is not supported on these builds.

dangermattic · 2024-01-25T01:27:38Z

	1 Error
🚫	This PR is tagged with `Do Not Merge` label(s).

Generated by 🚫 Danger

derekblank · 2024-01-25T03:41:07Z

…dpress-mobile/WordPress-Android into gutenberg/test-image-uploads

wpmobilebot · 2024-01-25T06:53:20Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
-|    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.111.1
-|         +--- com.facebook.fresco:animated-gif:2.0.0
-|         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-|         |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |    \--- com.facebook.fresco:animated-base:2.0.0
-|         |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-|         |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-|         |         +--- com.facebook.fresco:animated-drawable:2.0.0
-|         |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-|         |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-|         |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         \--- com.parse.bolts:bolts-tasks:1.4.0
-|         +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-|         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
-|         |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    |    |    \--- com.google.guava:guava:27.1-android
-|         |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-|         |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-|         |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-|         |    |         \--- androidx.media:media:1.2.1 (*)
-|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-|         |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-|         |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
-|         |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
-|         +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
-|         |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
-|         |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-|         |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-|         |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-|         |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
-|         |    \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
-|         |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
-|         |    \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
-|         |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
-|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
-|         |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-|         |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
-|         |    |    +--- com.github.bumptech.glide:annotations:4.15.1
-|         |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|         |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
-|         |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-|         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-|         |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
-|         |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
-|         |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
-|         |    +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-|         |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-|         |    +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.10 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
-|         +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.111.1
-|         |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-|         |    +--- androidx.gridlayout:gridlayout:1.0.0
-|         |    |    +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
-|         |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-|         |    +--- androidx.cardview:cardview:1.0.0 (*)
-|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
-|         |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-|         |    +--- org.wordpress:aztec:v1.9.0 (*)
-|         |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 (*)
-|         |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 (*)
-|         |    +--- org.wordpress.aztec:glide-loader:v1.9.0
-|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-|         |    |    +--- org.wordpress:aztec:v1.9.0 (*)
-|         |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+|    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:6550-71c38e861e8732adbca83e878816b32a9fe9d6a5 FAILED
 +--- org.wordpress:login:1.10.0
-|    \--- androidx.gridlayout:gridlayout:1.0.0 (*)
+|    \--- androidx.gridlayout:gridlayout:1.0.0
+|         +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+|         \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
 +--- com.automattic:stories:2.4.0
-|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1
+|         +--- com.github.bumptech.glide:gifdecoder:4.15.1
+|         |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+|         +--- com.github.bumptech.glide:disklrucache:4.15.1
+|         +--- com.github.bumptech.glide:annotations:4.15.1
+|         +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+|         +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|         +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
+|         \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-\--- com.google.android.exoplayer:exoplayer:2.13.3 (*)
+\--- com.google.android.exoplayer:exoplayer:2.13.3
+     +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+     |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+     |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     |    |    \--- com.google.guava:guava:27.1-android
+     |    |         +--- com.google.guava:failureaccess:1.0.1
+     |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+     |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+     |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+     +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+     |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+     |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+     |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+     +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+     |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+     |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+     |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+     |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+     \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          \--- androidx.media:media:1.2.1 (*)

Please review and act accordingly

derekblank · 2024-01-31T22:10:00Z

Closing, no longer needed.

Update Gutenberg ref

08a1739

derekblank added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jan 17, 2024

derekblank self-assigned this Jan 17, 2024

Update Gutenberg ref

e83cb4d

derekblank mentioned this pull request Jan 18, 2024

[RNMobile] Update Image component to avoid flicker when updating the URI WordPress/gutenberg#57869

Merged

derekblank added 3 commits January 18, 2024 17:18

Update Gutenberg ref

623aa2a

Update Gutenberg ref

e04d2ea

Merge branch 'trunk' into gutenberg/test-image-uploads

1480021

derekblank added the Do Not Merge label Jan 25, 2024

derekblank added 2 commits January 25, 2024 16:34

Update Gutenberg ref

46ddea8

Merge branch 'gutenberg/test-image-uploads' of https://github.com/wor…

97480f5

…dpress-mobile/WordPress-Android into gutenberg/test-image-uploads

derekblank added 3 commits January 31, 2024 14:30

Update Gutenberg ref

7b483ac

Update Gutenberg ref

3c1eaa7

Update Gutenberg ref

943b70f

derekblank closed this Jan 31, 2024

jkmassel deleted the gutenberg/test-image-uploads branch October 17, 2024 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] Test persisting local media files when uploading images#19963

[Gutenberg] Test persisting local media files when uploading images#19963
derekblank wants to merge 10 commits into
trunkfrom
gutenberg/test-image-uploads

derekblank commented Jan 17, 2024

Uh oh!

wpmobilebot commented Jan 17, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 17, 2024 •

edited

Loading

Uh oh!

dangermattic commented Jan 25, 2024

Uh oh!

derekblank commented Jan 25, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 25, 2024

Uh oh!

derekblank commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

derekblank commented Jan 17, 2024

Regression Notes

PR Submission Checklist:

UI Changes Testing Checklist:

Uh oh!

wpmobilebot commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Jan 25, 2024

Uh oh!

derekblank commented Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Testing

Image

Gallery

MediaText

MultipleUpload

Cover

Uh oh!

wpmobilebot commented Jan 25, 2024

The PR caused the following dependency changes:

Uh oh!

derekblank commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wpmobilebot commented Jan 17, 2024 •

edited

Loading

wpmobilebot commented Jan 17, 2024 •

edited

Loading

derekblank commented Jan 25, 2024 •

edited

Loading