Use a narrow type for htmlElementAttributes#14
Open
mkantor wants to merge 1 commit intowooorm:mainfrom
Open
Conversation
mkantor
commented
Sep 15, 2025
| * @type {Record<string, Array<string>>} | ||
| */ | ||
| export const htmlElementAttributes = { | ||
| export const htmlElementAttributes = /** @type {const} */ ({ |
Author
There was a problem hiding this comment.
This file wasn't actually regenerated, just manually edited. I did run the generator but it also spat out a bunch of other changes that I thought you'd want to review separately.
A [const assertion][1] is now used for `htmlElementAttributes` to make its TypeScript type include specific element & attribute names. [1]: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#const-assertions
mkantor
force-pushed
the
narrow-type
branch
from
1149d42 to
7f7648e
Compare
Author
|
If you like this then I could send similar pull requests to your related projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A const assertion is now used for
htmlElementAttributesto make its TypeScript type include specific element & attribute names.Here's what the type looks like now: