Skip to content

Remove custom richtext package for email editor#63289

Merged
triple0t merged 4 commits intotrunkfrom
remove-custom-richtext-for-email-editor
Feb 23, 2026
Merged

Remove custom richtext package for email editor#63289
triple0t merged 4 commits intotrunkfrom
remove-custom-richtext-for-email-editor

Conversation

@costasovo
Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

We added a custom RichText package for the email editor to support Personalization tags in WordPress 6.7.
The most recent changes in Gutenberg (WordPress/gutenberg#75387) are incompatible with our old custom package. We support WordPress 6.8+ so we can remove the custom package and use the package directly from core.

Closes WOOPRD-2309.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Verify that RichText in email editor works as expected and that you can insert Personalization tags

Testing that has already taken place:

Milestone

Note: Check the box above to have the milestone automatically assigned when merged.
Alternatively (e.g. for point releases), manually assign the appropriate milestone.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@costasovo costasovo requested a review from a team as a code owner February 13, 2026 12:46
@costasovo costasovo requested a review from triple0t February 13, 2026 12:46
@github-actions
Copy link
Copy Markdown
Contributor

Email Editor Testing (WordPress.com)

Are you an Automattician? If this PR relates to email rendering or reading site data, please test it on WordPress.com.

To test, run the downloader script on your sandbox:

bash bin/woocommerce-email-editor-downloader test 63289

To remove the changes after testing:

bash bin/woocommerce-email-editor-downloader reset

For a complete list of steps, see: PCYsg-19om-p2

@github-actions
Copy link
Copy Markdown
Contributor

Testing Guidelines

Hi @triple0t @woocommerce/ballade,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 13, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Removes the custom RichText bundle and its asset manifest, deletes README guidance about the bundle, drops the PHP logic that swapped in the custom wp-rich-text, removes the build-time copy of those assets, and adds changelog entries documenting the removal.

Changes

Cohort / File(s) Summary
RichText Bundle Removal
packages/js/email-editor/assets/rich-text.js, packages/js/email-editor/assets/rich-text.asset.php
Deleted the compiled rich-text bundle and its asset manifest, removing the bundle's public API surface and static asset metadata.
Documentation Update
packages/js/email-editor/README.md
Removed the Rich-text dependency note and minimum-version/replacement guidance from the Dependencies section.
PHP Asset Loading
packages/php/email-editor/src/Engine/class-assets-manager.php
Removed the block in load_editor_assets that located/required the custom rich-text assets, deregistered and re-enqueued wp-rich-text.
Build Configuration
plugins/woocommerce/client/admin/webpack.config.js
Removed the CopyWebpackPlugin step that copied packages/js/email-editor/assets into the plugin build output.
Changelog Entries
packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor, packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor, plugins/woocommerce/changelog/remove-custom-richtext-for-email-editor
Added changelog files noting removal of the custom RichText package.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Build as Build (Webpack)
participant Assets as Package Assets
participant PHP as PHP Assets Manager
participant Editor as Email Editor (client)
rect rgba(220,220,255,0.5)
Note left of Build: Previous flow (with custom bundle)
Build->>Assets: Copy rich-text assets into plugin build
Assets->>PHP: Asset files available
PHP->>Editor: Deregister core wp-rich-text, enqueue custom wp-rich-text
Editor->>Editor: Use bundled rich-text API
end
rect rgba(255,220,220,0.5)
Note left of Build: New flow (use core)
Build->>Assets: No copy step
Assets-->>PHP: No custom rich-text asset provided
PHP->>Editor: Do not replace wp-rich-text; use core script
Editor->>Editor: Use platform-provided rich-text API
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing a custom RichText package for the email editor.
Description check ✅ Passed The description is directly related to the changeset, providing context for why the custom RichText package is being removed and how to test the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-custom-richtext-for-email-editor

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor`:
- Around line 1-2: Update the changelog entry that currently sets "Significance:
minor" for the "remove-custom-richtext-for-email-editor" change to
"Significance: major" and keep or adjust "Type: update"; also update the
changelog text to explicitly mention this is a breaking change for WordPress 6.7
users (since removal of the custom RichText breaks compatibility with WP < 6.8)
so the release notes and semver reflect the break.

In `@packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor`:
- Line 4: The changelog entry contains a typo: replace "enqueing" with the
correct spelling "enqueuing" in the description text "Removed enqueing of custom
RichText package that was needed for WordPress < 6.8" so it reads "Removed
enqueuing of custom RichText package that was needed for WordPress < 6.8".

Comment thread packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor Outdated
@costasovo costasovo force-pushed the remove-custom-richtext-for-email-editor branch 2 times, most recently from 3093c7d to 2e637df Compare February 13, 2026 14:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2026

Size Change: -12 kB (-0.2%)

Total Size: 5.97 MB

Filename Size Change
./plugins/woocommerce/client/admin/build/email-editor/assets/rich-text.js 0 B -12 kB (removed) 🏆

compressed-size-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2026

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@triple0t triple0t force-pushed the remove-custom-richtext-for-email-editor branch from 2e637df to 282ccd7 Compare February 23, 2026 14:38
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/woocommerce/changelog/remove-custom-richtext-for-email-editor`:
- Line 3: Fix the typo "skipe" -> "skip" in the changelog comment that reads
"Updated build of admin scripts to skipe custom RichText package for email
editor" so the message becomes "Updated build of admin scripts to skip custom
RichText package for email editor"; update the changelog entry text containing
"skipe" to the corrected spelling.

ℹ️ Review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e637df and 282ccd7.

📒 Files selected for processing (8)
  • packages/js/email-editor/README.md
  • packages/js/email-editor/assets/rich-text.asset.php
  • packages/js/email-editor/assets/rich-text.js
  • packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor
  • packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor
  • packages/php/email-editor/src/Engine/class-assets-manager.php
  • plugins/woocommerce/changelog/remove-custom-richtext-for-email-editor
  • plugins/woocommerce/client/admin/webpack.config.js
💤 Files with no reviewable changes (5)
  • packages/js/email-editor/assets/rich-text.js
  • packages/php/email-editor/src/Engine/class-assets-manager.php
  • packages/js/email-editor/assets/rich-text.asset.php
  • packages/js/email-editor/README.md
  • plugins/woocommerce/client/admin/webpack.config.js
✅ Files skipped from review due to trivial changes (1)
  • packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor

Copy link
Copy Markdown
Contributor

@triple0t triple0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@triple0t triple0t merged commit 5cad66a into trunk Feb 23, 2026
46 checks passed
@triple0t triple0t deleted the remove-custom-richtext-for-email-editor branch February 23, 2026 15:27
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 23, 2026
@github-actions github-actions bot added this to the 10.7.0 milestone Feb 23, 2026
@triple0t triple0t assigned costasovo and unassigned triple0t Feb 23, 2026
@triple0t triple0t mentioned this pull request Feb 23, 2026
13 tasks
@triple0t triple0t modified the milestones: 10.7.0, 10.6.0 Feb 25, 2026
@tpaksu tpaksu restored the remove-custom-richtext-for-email-editor branch February 25, 2026 09:02
github-actions bot pushed a commit that referenced this pull request Feb 25, 2026
* Remove enqueing of the custom richtext package

* Remove the custom Richtext package from the email editor

* Add changelog

* Update Woo admin assets build
@woocommercebot
Copy link
Copy Markdown
Collaborator

IMPORTANT: Merging this PR to the appropriate branches is critical to the release process and ensures that the bug does not cause regressions in the future releases.

Cherry picking was successful for release/10.6. Please merge the following PR: [Backport to release/10.6] Remove custom richtext package for email editor

triple0t pushed a commit that referenced this pull request Feb 25, 2026
…ditor (#63444)

Remove custom richtext package for email editor (#63289)

* Remove enqueing of the custom richtext package

* Remove the custom Richtext package from the email editor

* Add changelog

* Update Woo admin assets build

Co-authored-by: Rostislav Wolný <1082140+costasovo@users.noreply.github.com>
samnajian pushed a commit that referenced this pull request Mar 11, 2026
* Remove enqueing of the custom richtext package

* Remove the custom Richtext package from the email editor

* Add changelog

* Update Woo admin assets build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants