Remove custom richtext package for email editor#63289
Conversation
Email Editor Testing (WordPress.com)Are you an Automattician? If this PR relates to email rendering or reading site data, please test it on WordPress.com. To test, run the downloader script on your sandbox: bash bin/woocommerce-email-editor-downloader test 63289To remove the changes after testing: bash bin/woocommerce-email-editor-downloader resetFor a complete list of steps, see: PCYsg-19om-p2 |
Testing GuidelinesHi @triple0t @woocommerce/ballade, Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoves the custom RichText bundle and its asset manifest, deletes README guidance about the bundle, drops the PHP logic that swapped in the custom Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor`:
- Around line 1-2: Update the changelog entry that currently sets "Significance:
minor" for the "remove-custom-richtext-for-email-editor" change to
"Significance: major" and keep or adjust "Type: update"; also update the
changelog text to explicitly mention this is a breaking change for WordPress 6.7
users (since removal of the custom RichText breaks compatibility with WP < 6.8)
so the release notes and semver reflect the break.
In `@packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor`:
- Line 4: The changelog entry contains a typo: replace "enqueing" with the
correct spelling "enqueuing" in the description text "Removed enqueing of custom
RichText package that was needed for WordPress < 6.8" so it reads "Removed
enqueuing of custom RichText package that was needed for WordPress < 6.8".
3093c7d to
2e637df
Compare
|
Size Change: -12 kB (-0.2%) Total Size: 5.97 MB
|
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
2e637df to
282ccd7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/woocommerce/changelog/remove-custom-richtext-for-email-editor`:
- Line 3: Fix the typo "skipe" -> "skip" in the changelog comment that reads
"Updated build of admin scripts to skipe custom RichText package for email
editor" so the message becomes "Updated build of admin scripts to skip custom
RichText package for email editor"; update the changelog entry text containing
"skipe" to the corrected spelling.
ℹ️ Review info
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
packages/js/email-editor/README.mdpackages/js/email-editor/assets/rich-text.asset.phppackages/js/email-editor/assets/rich-text.jspackages/js/email-editor/changelog/remove-custom-richtext-for-email-editorpackages/php/email-editor/changelog/remove-custom-richtext-for-email-editorpackages/php/email-editor/src/Engine/class-assets-manager.phpplugins/woocommerce/changelog/remove-custom-richtext-for-email-editorplugins/woocommerce/client/admin/webpack.config.js
💤 Files with no reviewable changes (5)
- packages/js/email-editor/assets/rich-text.js
- packages/php/email-editor/src/Engine/class-assets-manager.php
- packages/js/email-editor/assets/rich-text.asset.php
- packages/js/email-editor/README.md
- plugins/woocommerce/client/admin/webpack.config.js
✅ Files skipped from review due to trivial changes (1)
- packages/js/email-editor/changelog/remove-custom-richtext-for-email-editor
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/php/email-editor/changelog/remove-custom-richtext-for-email-editor
* Remove enqueing of the custom richtext package * Remove the custom Richtext package from the email editor * Add changelog * Update Woo admin assets build
|
IMPORTANT: Merging this PR to the appropriate branches is critical to the release process and ensures that the bug does not cause regressions in the future releases. Cherry picking was successful for |
…ditor (#63444) Remove custom richtext package for email editor (#63289) * Remove enqueing of the custom richtext package * Remove the custom Richtext package from the email editor * Add changelog * Update Woo admin assets build Co-authored-by: Rostislav Wolný <1082140+costasovo@users.noreply.github.com>
* Remove enqueing of the custom richtext package * Remove the custom Richtext package from the email editor * Add changelog * Update Woo admin assets build
Changes proposed in this Pull Request:
We added a custom RichText package for the email editor to support Personalization tags in WordPress 6.7.
The most recent changes in Gutenberg (WordPress/gutenberg#75387) are incompatible with our old custom package. We support WordPress 6.8+ so we can remove the custom package and use the package directly from core.
Closes WOOPRD-2309.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Testing that has already taken place:
Milestone
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment