Skip to content

chore: improve python-progressbar maintenance path #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolph merged 2 commits into from
Jul 6, 2026
+54 −0
Merged

chore: improve python-progressbar maintenance path #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f0b275
chore: improve python-progressbar maintenance path
lphuc2250gma May 25, 2026
877a41e
Merge develop into maint/20260525120751
wolph Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,60 @@ def raise_error():
assert not progressbar.env.is_ansi_terminal(fd)


@pytest.mark.parametrize(
'value,expected',
[
('', ''),
(b'', b''),
('\x1b[31m', ''),
(b'\x1b[31m', b''),
('\x1b[1m\x1b[31mtext\x1b[0m', 'text'),
(b'\x1b[1m\x1b[31mtext\x1b[0m', b'text'),
('\x1b[38;5;208mhello world\x1b[0m', 'hello world'),

@gemini-code-assist gemini-code-assist Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a test case for 24-bit (TrueColor) ANSI sequences to ensure they are also correctly stripped by no_color.

        ('\x1b[38;5;208mhello world\x1b[0m', 'hello world'),
        ('\x1b[38;2;255;0;0mred\x1b[0m', 'red'),

],
)
def test_no_color(value, expected) -> None:
assert progressbar.utils.no_color(value) == expected

@gemini-code-assist gemini-code-assist Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The tests use progressbar.utils, but this submodule is not explicitly imported in the file. Given that progressbar.env is explicitly imported at line 6, it is recommended to also explicitly import progressbar.utils at the top of the file to ensure the tests run correctly and maintain consistency with the existing import style.



def test_no_color_type_error() -> None:
with pytest.raises(TypeError):
progressbar.utils.no_color(123)


@pytest.mark.parametrize(
'value,expected',
[
('', 0),
(b'', 0),

@gemini-code-assist gemini-code-assist Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While test_len_color includes an empty bytes case, it would be beneficial to add a test case for bytes containing ANSI escape sequences to ensure len_color handles bytes with formatting correctly, similar to the string cases.

Suggested change
(b'', 0),
(b'', 0),
(b'\x1b[31mtext\x1b[0m', 4),

('\x1b[31m', 0),
('\x1b[1m\x1b[31mtext\x1b[0m', 4),
('\x1b[38;5;208mhello world\x1b[0m', 11),
],
)
def test_len_color(value, expected) -> None:
assert progressbar.utils.len_color(value) == expected


def test_attribute_dict_empty() -> None:
attrs = progressbar.utils.AttributeDict()
assert len(attrs) == 0
with pytest.raises(AttributeError):
_ = attrs.missing


def test_attribute_dict_set_get_del() -> None:
attrs = progressbar.utils.AttributeDict()
attrs.spam = 123
assert attrs['spam'] == 123
assert attrs.spam == 123
del attrs.spam
with pytest.raises(AttributeError):
_ = attrs.spam
with pytest.raises(AttributeError):
del attrs.spam


def test_stream_wrapper_unwrap_restores_excepthook() -> None:
# Regression: C7 - unwrap_stdout/unwrap_stderr left the custom
# excepthook installed forever.
Expand Down
Loading