fish/4.3.1 package update

[octo-sts]

Commit: a2c5b2a56723fb7c3f63a0bf3eefaf1e94db6332

Note: If you need to make manual changes to this PR, apply the skip:staging-update-bot label so the reconciler won't overwrite them.

[octo-sts]

⚙️ Build Failed: Configuration

CMake Error at cmake/Docs.cmake:44 (message): the BUILD_DOCS option is no longer supported, use -DWITH_DOCS=ON|OFF

Build Details

Category	Details
Build System	cmake
Failure Point	cmake configuration step with -DBUILD_DOCS=TRUE flag

Root Cause Analysis 🔍

The fish-shell project has deprecated the BUILD_DOCS CMake option and replaced it with WITH_DOCS. The build configuration is using the old flag name (-DBUILD_DOCS=TRUE) which is no longer supported by the project's CMake configuration.

---

🔍 Build failure fix suggestions

Found similar build failures that have been fixed in the past and analyzed them to suggest a fix:

Suggested Changes

File: fish.yaml

• modification at line 37 (cmake/configure opts section)
  Original:

-DBUILD_DOCS=TRUE

Replacement:

-DWITH_DOCS=ON

Content:

Replace the deprecated BUILD_DOCS flag with the new WITH_DOCS flag

Click to expand fix analysis

Analysis

No similar build failures were found in the historical data, but the error message clearly indicates that the fish-shell project has deprecated the BUILD_DOCS CMake option in favor of WITH_DOCS. This is a straightforward CMake configuration flag rename that requires updating the build configuration to use the new flag name.

Click to expand fix explanation

Explanation

The fish-shell project has deprecated the BUILD_DOCS CMake option and replaced it with WITH_DOCS. The error message explicitly states 'the BUILD_DOCS option is no longer supported, use -DWITH_DOCS=ON|OFF'. This is a direct flag rename where BUILD_DOCS=TRUE becomes WITH_DOCS=ON. The fix is straightforward: replace -DBUILD_DOCS=TRUE with -DWITH_DOCS=ON in the CMake configuration options. This maintains the same functionality (enabling documentation build) while using the new flag name that the project now expects.

Click to expand alternative approaches

Alternative Approaches

• Disable documentation building entirely by using -DWITH_DOCS=OFF if documentation is not needed
• Remove the documentation flag altogether if the default behavior is acceptable, though this may result in documentation not being built

---

Was this comment helpful? Please use 👍 or 👎 reactions on this comment.