Skip to content

Improve log message and error code for invalid HelloRetryRequest - fix #9653 #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
holtrop-wolfssl wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Draft

Improve log message and error code for invalid HelloRetryRequest - fix #9653 #9659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tls13.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5677,7 +5677,9 @@ int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
#endif
) {
SendAlert(ssl, alert_fatal, illegal_parameter);
return DUPLICATE_MSG_E;
/* issue 9653: use a more appropriate error than DUPLICATE_MSG_E.
Copy link
Contributor

@SparkiDev SparkiDev Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put in issue numbers into code.
Tests, maybe, code no.

* Since the cause of this is missing extension, return that. */
return EXT_MISSING;
}

ssl->options.tls1_3 = 1;
Expand Down
2 changes: 1 addition & 1 deletion tests/api/test_tls13.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2355,7 +2355,7 @@ int test_tls13_same_ch(void)
ExpectIntEQ(test_memio_inject_message(&test_ctx, 1, (char*)hrr,
sizeof(hrr)), 0);
ExpectIntEQ(wolfSSL_connect(ssl_c), -1);
ExpectIntEQ(wolfSSL_get_error(ssl_c, -1), DUPLICATE_MSG_E);
ExpectIntEQ(wolfSSL_get_error(ssl_c, -1), EXT_MISSING);

wolfSSL_free(ssl_c);
wolfSSL_CTX_free(ctx_c);
Expand Down
Loading