fix for nightly memory allocation test cases with LMS#10739
Open
JacobBarthelmeh wants to merge 1 commit into
Open
fix for nightly memory allocation test cases with LMS#10739JacobBarthelmeh wants to merge 1 commit into
JacobBarthelmeh wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LMS/XMSS API tests to behave safely under simulated allocation-failure conditions (nightly LMS memory allocation tests), primarily by ensuring stack-allocated crypto objects are in a known state before init/cleanup paths run.
Changes:
- Zero-initialize
LmsKey/XmssKeyandWC_RNGlocals so cleanup is safe if initialization is skipped due to early failures. - Adjust ECC leaf key cleanup tracking in the RFC 9802 chain-generation helper to avoid freeing an uninitialized
ecc_key.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
868
to
871
| ExpectIntEQ(wc_ecc_init(&leafKey), 0); | ||
| leafKeyInit = 1; | ||
| if (EXPECT_SUCCESS()) /* only flag for free if init ran and succeeded */ | ||
| leafKeyInit = 1; | ||
| ExpectIntEQ(wc_ecc_make_key(rng, 32, &leafKey), 0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.