bsdkm: fix bsdkm build with rdseed.#10736
Open
philljj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets the FreeBSD kernel module (bsdkm) build, addressing a build failure when RDSEED support is enabled by ensuring wolfcrypt/src/random.c receives the necessary compile flag adjustments to find x86 intrinsic headers.
Changes:
- Updates
bsdkm/Makefileto includerandom.cin the set of sources receiving special per-file CFLAGS adjustments intended for x86 intrinsic/SIMD builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
84
to
86
| .if ${ENABLED_ASM} == "yes" | ||
| .for f in chacha dilithium poly1305 sha sha256 sha3 sha512 | ||
| .for f in chacha dilithium poly1305 sha sha256 sha3 sha512 random | ||
| CFLAGS.${f}.c += ${WOLFKMOD_SIMD_BASE} |
Contributor
Author
There was a problem hiding this comment.
Not sure worth the extra complexity for an obscure build scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix build error with rdseed.
Testing