Fix compiling when WOLFSSH_NO_NISTP256_MLKEM768_SHA256 is defined.#887
Fix compiling when WOLFSSH_NO_NISTP256_MLKEM768_SHA256 is defined.#887tjko wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Pull request overview
Fixes a compile-time guard so KEXKEM message IDs remain available when only one of the ML-KEM768 SHA256 KEX variants is enabled (e.g., NIST P-256 disabled but Curve25519 still enabled), addressing build failures reported in #886.
Changes:
- Update
#ifndef WOLFSSH_NO_NISTP256_MLKEM768_SHA256to a combined preprocessor condition that accounts for both NISTP256 and Curve25519 ML-KEM768 SHA256 KEX options. - Apply the same guard update for both
MSGID_KEXKEM_INITandMSGID_KEXKEM_REPLY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Btw, seems like this check should also include |
|
Could you remove the two guard checks and then squash the PR? |
|
This uncovered another bug. I have a fix for it. I'll need to get it merged before this. |
I think I ran into that same issue (?) when trying to only have "mlkem768x25519-sha256" support enabled: (update: looks like #889 fixes the issue I noticed) |
See #886