Harden fail-closed handling, fix mutex leaks, and add mutation-verified tests#84
Open
JeremiahM37 wants to merge 4 commits into
Open
Harden fail-closed handling, fix mutex leaks, and add mutation-verified tests#84JeremiahM37 wants to merge 4 commits into
JeremiahM37 wants to merge 4 commits into
Conversation
de383b6 to
451b106
Compare
douzzer
requested changes
May 15, 2026
Collaborator
douzzer
left a comment
There was a problem hiding this comment.
There's a couple false positives in the mix here -- the mitigations for them need to be reverted:
F-2836 "route_flags_to_add_on_insert accepts GREENLISTED flag, enabling auto-accept of all inserted routes"
F-2840 "route_flags_to_clear_on_insert accepts PENALTYBOXED flag without validation, bypassing penalty boxing for inserted routes"
I've closed the Fenrir issues as WontFix.
Collaborator
|
Also it would be good to have dispatch errors in the glue layer invoke the default policy, though that would be tricky. E.g. clearly there's no way to discover the default policy if the wolfsentry context is null -- ABRT seems reasonable there. But when there's a context to check, we should use its default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-2060, F-2061, F-2438, F-2445, F-2446, F-2456, F-2458, F-2459, F-2460, F-2461, F-2464, F-2465, F-2836, F-2837, F-2838, F-2840, F-3866, F-3867, F-3869, F-3873