Merged
Conversation
c10898f to
55cbb83
Compare
55cbb83 to
644f0f5
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for IORING_SETUP_SQ_REWIND (liburing ≥ 2.14) as a new RuntimeOptions toggle, and wires it into Runtime initialization, with a corresponding runtime-options test.
Changes:
- Add
RuntimeOptions::enable_sq_rewind()(guarded by liburing version) and track it via a newenable_sq_rewind_flag. - Apply
IORING_SETUP_SQ_REWINDtoio_uring_params.flagswhen the option is enabled. - Add a gated test case validating that a runtime can be constructed and execute many spawned tasks with
sq_rewindenabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_runtime_options.cpp | Adds a liburing-version-gated test for enable_sq_rewind and fixes the preprocessor closing for the preceding enable_no_mmap test block. |
| include/condy/runtime_options.hpp | Introduces enable_sq_rewind() and enforces mutual exclusion with sqpoll; refines mutual-exclusion error messages among related options. |
| include/condy/runtime.hpp | Sets IORING_SETUP_SQ_REWIND during ring initialization when enabled in RuntimeOptions (guarded by liburing version). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for linux 7.0