Skip to content

support sq_rewind#36

Merged
wokron merged 2 commits intomasterfrom
support-sq-rewind
Apr 15, 2026
Merged

support sq_rewind#36
wokron merged 2 commits intomasterfrom
support-sq-rewind

Conversation

@wokron
Copy link
Copy Markdown
Owner

@wokron wokron commented Feb 9, 2026

for linux 7.0

@wokron wokron changed the title support sq_rewind [Next] support sq_rewind Mar 3, 2026
@wokron wokron marked this pull request as draft March 31, 2026 14:43
@wokron wokron force-pushed the support-sq-rewind branch from 55cbb83 to 644f0f5 Compare April 14, 2026 04:57
@wokron wokron changed the title [Next] support sq_rewind support sq_rewind Apr 14, 2026
@wokron wokron marked this pull request as ready for review April 14, 2026 05:59
@wokron wokron requested a review from Copilot April 14, 2026 06:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for IORING_SETUP_SQ_REWIND (liburing ≥ 2.14) as a new RuntimeOptions toggle, and wires it into Runtime initialization, with a corresponding runtime-options test.

Changes:

  • Add RuntimeOptions::enable_sq_rewind() (guarded by liburing version) and track it via a new enable_sq_rewind_ flag.
  • Apply IORING_SETUP_SQ_REWIND to io_uring_params.flags when the option is enabled.
  • Add a gated test case validating that a runtime can be constructed and execute many spawned tasks with sq_rewind enabled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/test_runtime_options.cpp Adds a liburing-version-gated test for enable_sq_rewind and fixes the preprocessor closing for the preceding enable_no_mmap test block.
include/condy/runtime_options.hpp Introduces enable_sq_rewind() and enforces mutual exclusion with sqpoll; refines mutual-exclusion error messages among related options.
include/condy/runtime.hpp Sets IORING_SETUP_SQ_REWIND during ring initialization when enabled in RuntimeOptions (guarded by liburing version).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wokron wokron merged commit d958649 into master Apr 15, 2026
15 checks passed
@wokron wokron deleted the support-sq-rewind branch April 15, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants