run_finch: Support Finch request timeout option#506
Merged
wojtekmach merged 5 commits intowojtekmach:mainfrom Mar 12, 2026
Merged
run_finch: Support Finch request timeout option#506wojtekmach merged 5 commits intowojtekmach:mainfrom
run_finch: Support Finch request timeout option#506wojtekmach merged 5 commits intowojtekmach:mainfrom
Conversation
Owner
|
Thank you for the PR. Please document it in Req.new/1 and Req.Steps.run_finch/1 and add a run_finch test where passing request_timeout: 0 will end up with timeout error. |
Contributor
Author
|
thanks for the review, I've pushed those changes |
wojtekmach
changed the title
run_finch: Support Finch request timeout option
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing the
:request_timeoutoption toFinch.request.