Skip to content

Rename Suffix… to PrefixedEntityIdParser #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiemowmde wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename Suffix… to PrefixedEntityIdParser #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EntityId/SuffixEntityIdParser.php → src/EntityId/PrefixedEntityIdParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* @license GPL-2.0+
* @author Daniel Kinzler
*/
class SuffixEntityIdParser implements EntityIdParser {
class PrefixedEntityIdParser implements EntityIdParser {

/**
* @var string
Expand Down
10 changes: 5 additions & 5 deletions ...nit/EntityId/SuffixEntityIdParserTest.php → ...t/EntityId/PrefixedEntityIdParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
use Wikibase\DataModel\Entity\EntityIdParsingException;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Services\EntityId\SuffixEntityIdParser;
use Wikibase\DataModel\Services\EntityId\PrefixedEntityIdParser;

/**
* @covers Wikibase\DataModel\Services\EntityId\SuffixEntityIdParser
* @covers Wikibase\DataModel\Services\EntityId\PrefixedEntityIdParser
*
* @license GPL-2.0+
* @author Daniel Kinzler
*/
class SuffixEntityIdParserTest extends \PHPUnit_Framework_TestCase {
class PrefixedEntityIdParserTest extends \PHPUnit_Framework_TestCase {

public function validInputProvider() {
return [
Expand All @@ -27,7 +27,7 @@ public function validInputProvider() {
* @dataProvider validInputProvider
*/
public function testParse( $prefix, $input, $expected ) {
$parser = new SuffixEntityIdParser( $prefix, new BasicEntityIdParser() );
$parser = new PrefixedEntityIdParser( $prefix, new BasicEntityIdParser() );
$this->assertEquals( $expected, $parser->parse( $input ) );
}

Expand All @@ -48,7 +48,7 @@ public function invalidInputProvider() {
* @dataProvider invalidInputProvider
*/
public function testParse_invalid( $prefix, $input ) {
$parser = new SuffixEntityIdParser( $prefix, new BasicEntityIdParser() );
$parser = new PrefixedEntityIdParser( $prefix, new BasicEntityIdParser() );

$this->setExpectedException( EntityIdParsingException::class );
$parser->parse( $input );
Expand Down