-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Switch to out of tree AudioReactive Usermod #5311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
netmindz
wants to merge
17
commits into
wled:main
Choose a base branch
from
netmindz:AR-Usermod-out-of-tree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0e15bf0
Remove in-tree audioreactive
netmindz 4df67e0
Use MoonModules/WLED-AudioReactive-Usermod
netmindz 5ad2287
custom_usermods is for in-tree only
netmindz d1aba86
Pull new ERR_ values into upstream
netmindz a489170
define library as name url combo
netmindz ea78f51
oappendi
netmindz e8ee8c0
Add missing javascript function from WLED-MM
netmindz 7e4fac8
Add missing javascript function from WLED-MM
netmindz 1f6a375
Revert "define library as name url combo"
netmindz 8a34925
Revert "custom_usermods is for in-tree only"
netmindz c23f6f2
Swap to using ${common.default_usermods} and new style syntax for out…
netmindz 676b56b
Revert "Use MoonModules/WLED-AudioReactive-Usermod"
netmindz 1dd7edd
Merge branch 'main' into AR-Usermod-out-of-tree
netmindz fd7fa1a
Merge remote-tracking branch 'AC/main' into AR-Usermod-out-of-tree
netmindz deab685
remove oappendi
netmindz d92f123
Merge branch 'main' into AR-Usermod-out-of-tree
netmindz 1d7011b
standardise on custom_usermods = ${common.default_usermods}
netmindz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to pin a specific version or commit? Otherwise old builds become non-reproducible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout, we should pin