-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Remove MAX_LEDS_PER_BUS limitation for virtual buses #5238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Frontend: Updated settings_leds.htm to allow virtual buses up to 16384 LEDs - Backend: Modified BusConfig::adjustBounds() to skip MAX_LEDS_PER_BUS check for virtual buses - Tests: All npm tests pass successfully Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
.gitignore
Outdated
| /wled00/Release | ||
| /wled00/wled00.ino.cpp | ||
| /wled00/html_*.h | ||
| _codeql_detected_source_root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Is it related to the rest of the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI artefact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI artefact.
|
@copilot please revert unnecessary change to .gitignore |
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Plan to Remove MAX_LEDS_PER_BUS Limitation for Virtual Buses
Based on the issue description and reference commit, virtual buses (like DDP, ArtNet, E131) are incorrectly limited to MAX_LEDS_PER_BUS (2048 on ESP32) when they should support up to MAX_LEDS (16384 on ESP32).
Changes Required:
Frontend (wled00/data/settings_leds.htm):
d.Sf["LC"+n].max = maxPBfor all bus typesif (nm=="LC")section to set max value based on bus type:maxLCcalculation to only apply for digital busesBackend (wled00/bus_manager.h):
BusConfig::adjustBounds()to only apply MAX_LEDS_PER_BUS limit to non-virtual busesTesting:
Address feedback:
Summary:
All changes are complete and validated. Virtual buses can now be configured with up to 16384 LEDs instead of being limited to 2048 LEDs. The implementation follows the reference commit and maintains backward compatibility for physical buses while removing the artificial limitation for virtual/network buses.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.