Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello and thank you for your work!
I have comited two fixes to the Persian contemporary bible,
Explenation
Fix: Added Hyphens to Separate the Names of Books Comprising Two Words
Reason: Book names consisting of two words were previously concatenated without spaces, leading to readability and usability issues. Adding hyphens improves clarity and consistency, facilitating easier coding and API calls.
Fix: Remove Diacritics in Book Names
Reason: Diacritics in book names created confusion, as they are not commonly used in Persian typing or writing, except for children. Removing them simplifies the names and avoids the need for developers to map diacritics to plain versions. This change enhances usability and aligns with common typing practices.
P.S.
All the changes are performed on the directory names. No modification has been applied to the json files or their contents.